From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 456103858413 for ; Fri, 4 Mar 2022 15:20:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 456103858413 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id B0FD510047FA4 for ; Fri, 4 Mar 2022 15:20:06 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Q9iwnlzkOkku4Q9iwn3qbp; Fri, 04 Mar 2022 15:20:06 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=SP+H6MjH c=1 sm=1 tr=0 ts=62222e26 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=j5SJ6g2Fq6aGLTe8MwsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/UscYg5HwtWf5/+MvVXyj6dRqGPDTnQ/n03AxqC2NiY=; b=FG3BvsE8uYduuZwqnVHxnrVKeG 5gaIZN/I1FROTfgb1PvgnqCOmj+87vPbKWocNm35ZeGLZ+tppKx6VuRwKwko6lQ6BiaQkHlUXnDUq VPkIZeUhL5rulrr8jPj6gt+8n; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37896 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nQ9iv-0019SL-RM; Fri, 04 Mar 2022 08:20:05 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: Aaron Merey , tom@tromey.com, aburgess@redhat.com, lsix@lancelotsix.com Subject: Re: [PATCH 2/2] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings References: <20220303013501.265407-1-amerey@redhat.com> <20220303013501.265407-3-amerey@redhat.com> X-Attribution: Tom Date: Fri, 04 Mar 2022 08:20:05 -0700 In-Reply-To: <20220303013501.265407-3-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Wed, 2 Mar 2022 20:35:01 -0500") Message-ID: <87wnh9u4m2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nQ9iv-0019SL-RM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37896 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 15:20:17 -0000 >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: Aaron> When core file shared libraries are found locally, verify that their Aaron> build-ids match the corresponding build-ids found in the core file. Aaron> If there is a mismatch, attempt to query debuginfod for the correct Aaron> build and print a warning if unsuccessful: Aaron> warning: Build-id of /lib64/libc.so.6 does not match core file. Nice. Aaron> + if (execbfd == nullptr) Aaron> + warning (_("File \"%s\" from debuginfod cannot be opened as bfd"), Aaron> + execpath.get ()); I suspect this should use gdb_bfd_errmsg. Aaron> + char *dname = nullptr; Aaron> + scoped_fd fd (debuginfod_find_executable (c, build_id, build_id_len, &dname)); Aaron> + debuginfod_set_user_data (c, nullptr); Aaron> + if (fd.get () >= 0) Aaron> + destname->reset (dname); Is it possible for fd.get()<0 and dname!=nullptr? If so there's a memory leak. Aaron> + gdb::unique_xmalloc_ptr build_id_hexstr = Aaron> + get_cbfd_soname_build_id (current_program_space->cbfd, so->so_name); '=' on the next line. Tom