From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Fix watchpoints with multiple threads on Windows
Date: Wed, 27 Oct 2021 14:15:23 -0600 [thread overview]
Message-ID: <87wnlyns10.fsf@tromey.com> (raw)
In-Reply-To: <20211006204322.2175432-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 6 Oct 2021 14:43:22 -0600")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> A recent internal change pointed out that watchpoints were not working
Tom> on Windows when the inferior was multi-threaded. This happened
Tom> because the debug registers were only updated for certain threads --
Tom> in particular, those that were being resumed and that were not marked
Tom> as suspended. In the case of single-stepping, the need to update the
Tom> debug registers in other threads could also be "forgotten".
Tom> This patch changes windows-nat.c to mark all threads needing a debug
Tom> register update. This brings the code closer to what gdbserver does
Tom> (though, unfortunately, it still seems more complicated than needed).
I'm going to check this in now.
Tom
prev parent reply other threads:[~2021-10-27 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 20:43 Tom Tromey
2021-10-27 20:15 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnlyns10.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).