From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id F0AD83858C27 for ; Wed, 27 Oct 2021 20:15:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F0AD83858C27 Received: by mail-il1-x12c.google.com with SMTP id j6so4347010ila.1 for ; Wed, 27 Oct 2021 13:15:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nPtmdjuP83HYdDv5K//osikdidvf32CWis7Hki26uNk=; b=u2iNB5oOgNtNZIRbQ0soh7kxov14ae6+fhpimeqJKC7f3MUhSu/b7UMHbHaXrqmwA9 XuqOVB+JWY87gdwJomb1c7NUzeA3rkc9DN4M/urrbDcP/Z0zy3tGtUuFT9EADD+ZHETn 3g0kubpSw8A0vGH2Na8+K0rxrlEsyvRAMaGQCOKKzAYxWxhW9XIEzI0qplgA1SnPNP8f XThtQuVN8iOVk/G8UL6s9A/dd+WgljecrKoNHfd3TF/ZrOzsIKdksn/+o5jPPdoDTCk9 vVUYpNHTCbaYlIr5+eOQ8kpLu5fkYlp/4EHIBWEO92zvBwm+eFd5IHQI/m+ii8JpZou0 E3jg== X-Gm-Message-State: AOAM530cnJX0yvQCSNKgyYxqlUvPmtvuI6zOZ6UJxZn/EXGyRMQ9Cb0B URjAQTrxGgbMrl23S3nPujStp0BQodRNCQ== X-Google-Smtp-Source: ABdhPJzaY/K3eLD+/9c8xAAC7ykWz5J3+JW/aAcsxxciW6T6DmW6wsiX8YGfMcohw057D7gY72jqVA== X-Received: by 2002:a92:ca0b:: with SMTP id j11mr2712332ils.289.1635365725434; Wed, 27 Oct 2021 13:15:25 -0700 (PDT) Received: from murgatroyd (174-16-0-219.hlrn.qwest.net. [174.16.0.219]) by smtp.gmail.com with ESMTPSA id v4sm445269ilq.57.2021.10.27.13.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 13:15:24 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Fix watchpoints with multiple threads on Windows References: <20211006204322.2175432-1-tromey@adacore.com> X-Attribution: Tom Date: Wed, 27 Oct 2021 14:15:23 -0600 In-Reply-To: <20211006204322.2175432-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 6 Oct 2021 14:43:22 -0600") Message-ID: <87wnlyns10.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 20:15:27 -0000 >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> A recent internal change pointed out that watchpoints were not working Tom> on Windows when the inferior was multi-threaded. This happened Tom> because the debug registers were only updated for certain threads -- Tom> in particular, those that were being resumed and that were not marked Tom> as suspended. In the case of single-stepping, the need to update the Tom> debug registers in other threads could also be "forgotten". Tom> This patch changes windows-nat.c to mark all threads needing a debug Tom> register update. This brings the code closer to what gdbserver does Tom> (though, unfortunately, it still seems more complicated than needed). I'm going to check this in now. Tom