From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id CD0DB386F41D for ; Sat, 13 Jun 2020 15:05:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CD0DB386F41D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ludo@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:58281) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk7iO-0006R2-Co; Sat, 13 Jun 2020 11:05:00 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44492 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jk7iM-0001uq-Vl; Sat, 13 Jun 2020 11:04:59 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Eli Zaretskii Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] guile: Add support for Guile 2.2. References: <20200612132710.14364-1-ludo@gnu.org> <20200612132710.14364-2-ludo@gnu.org> <83sgf04clq.fsf@gnu.org> <874krg8jo9.fsf@gnu.org> <83k10b4g8b.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Prairial an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 13 Jun 2020 17:04:57 +0200 In-Reply-To: <83k10b4g8b.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Jun 2020 09:44:36 +0300") Message-ID: <87wo4bypk6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2020 15:05:02 -0000 Hi, In the meantime I found that Doug had already done that work in 2018: https://sourceware.org/bugzilla/show_bug.cgi?id=3D21104#c8 Too bad I didn=E2=80=99t notice earlier. I=E2=80=99ll check if there are s= ignificant differences between the two. Eli Zaretskii skribis: >> These four functions are not used in tests, in documented examples, nor >> in Guile=E2=80=99s own GDB plugin. >>=20 >> =E2=80=98setvbuf=E2=80=99 is not entirely a drop-in replacement because:= (1) it doesn=E2=80=99t >> allow you to query a port=E2=80=99s buffer size, only to change it, and = (2) it >> doesn=E2=80=99t distinguish between the read and write buffers. Consequ= ently, >> these functions cannot be implemented on 2.2/3.0, or at least not >> easily. >>=20 >> Since they are unused, and I can=E2=80=99t see a valid use case for thos= e over >> =E2=80=98setvbuf=E2=80=99, I chose to remove them from the manual as a w= ay to deprecate >> them. >>=20 >> WDYT? > > So what is the plan wrt GDB accessing memory of the inferior via > Guile? Specifically, which parts of the features described in "Memory > Ports in Guile" in the manual will continue be supported with Guile 2.2 > and later? can we make at least the accessors work with those newer > versions of Guile? Yes, everything remains supported, it=E2=80=99s just setting read/write buffering size in that way that is unsupported. In most cases, I suspect one just wants an unbuffered memory port anyway. > In any case, I don't like the method of deprecating features by > removing their documentation. I think we should say explicitly in > that section which methods are deprecated and why. The fact that they > are deprecated should also be in NEWS. This all assumes that other > GDB developers agree that they are not needed; I don't have enough > relevant experience to have an opinion. Maybe Doug (CC'ed) could > chime in. Yes, I think we should mention it in =E2=80=98NEWS=E2=80=99. > I also think that Guile should provide proper replacements for the > functionality you mentioned, because evidently at least GDB thought > they could be put to good use. But this is outside of the scope of > GDB maintenance, something for the Guile developers to consider. Right. For I/O ports in general, I don=E2=80=99t think this functionality = would be very useful. (Even for GDB memory ports, I think =E2=80=98setvbuf=E2=80= =99 is enough.) >> > Also, does any of this need to be called out in NEWS? >>=20 >> Oh sure. Should that go in a separate commit or in the same? > > The same is better. Sounds good. Thanks, Ludo=E2=80=99.