From: Tom Tromey <tom@tromey.com>
To: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 0/3] Completer C++ template support
Date: Fri, 24 Apr 2020 14:15:32 -0600 [thread overview]
Message-ID: <87wo64zlln.fsf@tromey.com> (raw)
In-Reply-To: <20200420215708.42314-1-keiths@redhat.com> (Keith Seitz via Gdb-patches's message of "Mon, 20 Apr 2020 14:57:05 -0700")
>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
Keith> This small patch series fell of the map two years ago, but a recently
Keith> reported bug on the subject has spurred me into reviving this.
Keith> The original series is here
Keith> https://sourceware.org/pipermail/gdb-patches/2018-February/146790.html
Keith> This patch doesn't fix the newly reported bug (which I will follow-up with
Keith> in a later patch), but it does address a number of shortcomings when
Keith> completing on template parameters.
Is the newly-reported bug the one that Pedro mentioned in his review?
Anyway, aside from the nit I sent, this series looks good to me.
Tom
prev parent reply other threads:[~2020-04-24 20:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 21:57 Keith Seitz
2020-04-20 21:57 ` [PATCH v2 1/3] Move find_toplevel_char to utils.[ch] Keith Seitz
2020-04-24 19:57 ` Tom Tromey
2020-04-20 21:57 ` [PATCH v2 2/3] Remove hard-coded line number from templates.exp Keith Seitz
2020-04-24 19:58 ` Tom Tromey
2020-04-20 21:57 ` [PATCH v2 3/3] Support template lookups in strncmp_iw_with_mode Keith Seitz
2020-04-22 15:26 ` Simon Marchi
2020-04-24 20:14 ` Tom Tromey
2020-04-22 15:15 ` [PATCH v2 0/3] Completer C++ template support Simon Marchi
2020-04-22 17:27 ` Keith Seitz
2020-04-22 17:45 ` Simon Marchi
2020-04-24 20:15 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo64zlln.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).