From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.71]) by sourceware.org (Postfix) with ESMTPS id 2CC3E3893677 for ; Fri, 24 Apr 2020 20:15:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2CC3E3893677 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id A8A2C1E4F5E for ; Fri, 24 Apr 2020 15:15:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id S4jVjYgwqVQh0S4jVjh7XE; Fri, 24 Apr 2020 15:15:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1b3j6vUQa4rs+x47HbLulqXEfplpBv2X1Zr5t+1D/2U=; b=rm5TdYe7YJKf1SMoqVU6j4c0G3 e2EbBPWZcfEWXo3SFIHrGMbrQJSpFVnkjobOeSUxzZJy4NV+soggQJgpCykvHtu8PzP0cMHRcnIxK kv0Bsi/rlA+F2X986QWQO1Jbe; Received: from 184-96-229-138.hlrn.qwest.net ([184.96.229.138]:52666 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jS4jV-001cbU-E4; Fri, 24 Apr 2020 14:15:33 -0600 From: Tom Tromey To: Keith Seitz via Gdb-patches Subject: Re: [PATCH v2 0/3] Completer C++ template support References: <20200420215708.42314-1-keiths@redhat.com> X-Attribution: Tom Date: Fri, 24 Apr 2020 14:15:32 -0600 In-Reply-To: <20200420215708.42314-1-keiths@redhat.com> (Keith Seitz via Gdb-patches's message of "Mon, 20 Apr 2020 14:57:05 -0700") Message-ID: <87wo64zlln.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.229.138 X-Source-L: No X-Exim-ID: 1jS4jV-001cbU-E4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-229-138.hlrn.qwest.net (murgatroyd) [184.96.229.138]:52666 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 20:15:35 -0000 >>>>> "Keith" == Keith Seitz via Gdb-patches writes: Keith> This small patch series fell of the map two years ago, but a recently Keith> reported bug on the subject has spurred me into reviving this. Keith> The original series is here Keith> https://sourceware.org/pipermail/gdb-patches/2018-February/146790.html Keith> This patch doesn't fix the newly reported bug (which I will follow-up with Keith> in a later patch), but it does address a number of shortcomings when Keith> completing on template parameters. Is the newly-reported bug the one that Pedro mentioned in his review? Anyway, aside from the nit I sent, this series looks good to me. Tom