From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: replace some calls to internal_error with gdb_assert
Date: Thu, 02 Apr 2020 13:34:25 -0600 [thread overview]
Message-ID: <87wo6xu1fi.fsf@tromey.com> (raw)
In-Reply-To: <20200402174817.237657-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Thu, 2 Apr 2020 13:48:17 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> * exec.c (build_section_table): Replace internal_error with
Simon> gdb_assert.
Simon> (section_table_xfer_memory_partial): Likewise.
Simon> * mdebugread.c (parse_partial_symbols): Likewise.
Simon> * psymtab.c (lookup_partial_symbol): Likewise.
Simon> * utils.c (wrap_here): Likewise.
Looks good to me.
Tom
next prev parent reply other threads:[~2020-04-02 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 17:48 Simon Marchi
2020-04-02 19:34 ` Tom Tromey [this message]
2020-04-02 19:44 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo6xu1fi.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).