public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] gdb: print unknown part of flag enum in hex
Date: Tue, 18 Feb 2020 20:43:00 -0000	[thread overview]
Message-ID: <87wo8j62z1.fsf@tromey.com> (raw)
In-Reply-To: <20200213203035.30157-4-simon.marchi@efficios.com> (Simon	Marchi's message of "Thu, 13 Feb 2020 15:30:34 -0500")

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> When we print the "unknown" part of a flag enum, it is printed in
Simon> decimal.  I think it would be more useful if it was printed in hex, as
Simon> it helps to determine which bits are set more than a decimal value.

This seems fine to me.

Tom

  parent reply	other threads:[~2020-02-18 20:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 20:30 [PATCH 1/5] gnulib: import count-one-bits module and use it Simon Marchi
2020-02-13 20:30 ` [PATCH 3/5] gdb: allow duplicate enumerators in flag enums Simon Marchi
2020-02-17 11:01   ` Luis Machado
2020-02-18 20:38   ` Tom Tromey
2020-02-18 20:42     ` Tom Tromey
2020-02-18 20:48     ` Simon Marchi
2020-02-18 21:57       ` Tom Tromey
2020-02-18 22:25         ` Simon Marchi
2020-02-13 20:30 ` [PATCH 5/5] gdb: change print format of flag enums with value 0 Simon Marchi
2020-02-17 12:08   ` Luis Machado
2020-02-17 19:02     ` Simon Marchi
2020-02-18 20:45   ` Tom Tromey
2020-02-18 20:52     ` Simon Marchi
2020-02-13 20:30 ` [PATCH 2/5] gdb: fix printing of flag enums with multi-bit enumerators Simon Marchi
2020-02-17 10:56   ` Luis Machado
2020-02-17 17:27     ` Simon Marchi
2020-02-17 17:40       ` Luis Machado
2020-02-17 19:20         ` Simon Marchi
2020-02-18 20:42           ` Tom Tromey
2020-02-13 20:38 ` [PATCH 4/5] gdb: print unknown part of flag enum in hex Simon Marchi
2020-02-17 11:04   ` Luis Machado
2020-02-17 18:59     ` Simon Marchi
2020-02-18 20:43   ` Tom Tromey [this message]
2020-02-14 19:53 ` [PATCH 1/5] gnulib: import count-one-bits module and use it Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo8j62z1.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).