From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28060 invoked by alias); 28 Jun 2019 15:11:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28051 invoked by uid 89); 28 Jun 2019 15:11:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HTo:U*palves, day X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.188.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jun 2019 15:11:29 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 7A036400C5A06 for ; Fri, 28 Jun 2019 09:33:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gsX9hte0S2qH7gsX9h1tdY; Fri, 28 Jun 2019 10:11:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hx4VVm//nALNtqF1HeijMXdcJB8KYopCU+n6Z9dL+hY=; b=CwdsMOY45Xq0sqPK7BPCbpvHds Dx/csvJYKldbih0sPw0Xxoc4HrFkt05zV/szfqZ/3q42yOKnt2rBXc22AbQ8QAs4ufypjoYc36zfi rnd/yEJfjbtQWlGfYpFkJl97n; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:50452 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hgsX9-002dD9-Ju; Fri, 28 Jun 2019 10:11:27 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] Teach gdb::option about string options References: <20190627191427.20742-1-palves@redhat.com> <20190627191427.20742-4-palves@redhat.com> Date: Fri, 28 Jun 2019 15:11:00 -0000 In-Reply-To: <20190627191427.20742-4-palves@redhat.com> (Pedro Alves's message of "Thu, 27 Jun 2019 20:14:25 +0100") Message-ID: <87woh5zqw1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00632.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This commit adds support for string options, mapped to var_string. Pedro> For now, a string is parsed up until the first whitespace. I imagine Pedro> that we'll need to add support for quoting so that we could do: Pedro> (gdb) cmd -option 'some -string' Pedro> without gdb confusing the "-string" for an option. Pedro> This doesn't seem important for pipe, so I'm leaving it for another Pedro> day. I wonder if we should file bugs for known holes like this. On the one hand it seems nice to write down what we know. On the other hand, maybe nobody will ever look at these. Pedro> + /* Disable the copy constructor. */ Pedro> + option_def_and_value (const option_def_and_value &rval) = delete; I wonder if it makes sense to disable operator= as well. Tom