From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix some valgrind errors in the TUI
Date: Sun, 17 Feb 2019 15:35:00 -0000 [thread overview]
Message-ID: <87wolyl97d.fsf@tromey.com> (raw)
In-Reply-To: <20190212194621.13988-1-tom@tromey.com> (Tom Tromey's message of "Tue, 12 Feb 2019 12:46:21 -0700")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> The styling series introduced some new errors in the TUI -- the series
Tom> changed how source lines are allocated, without updating
Tom> tui_set_source_content_nil.
Tom> There are several failures but a typical one looks like:
Tom> ==6274== Use of uninitialised value of size 8
Tom> ==6274== at 0x4E4A095: wclrtoeol (in /usr/lib64/libncursesw.so.6.1)
Tom> ==6274== by 0x4E47617: waddch (in /usr/lib64/libncursesw.so.6.1)
Tom> ==6274== by 0x8325CB: tui_puts_internal(_win_st*, char const*, int*) (tui-io.c:393)
Tom> ==6274== by 0x82E89D: tui_file::puts(char const*) (tui-file.c:39)
Tom> ==6274== by 0x84BF5F: vfprintf_unfiltered(ui_file*, char const*, __va_list_tag*) (utils.c:2026)
Tom> This patch rewrites tui_set_source_content_nil, fixing the bug.
I'm going to check this in, to unblock the release.
Tom
prev parent reply other threads:[~2019-02-17 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 19:46 Tom Tromey
2019-02-17 15:35 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wolyl97d.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).