From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69012 invoked by alias); 15 Feb 2019 20:19:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68927 invoked by uid 89); 15 Feb 2019 20:19:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=actively X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.191) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Feb 2019 20:19:35 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 0AD76400EABB2 for ; Fri, 15 Feb 2019 14:19:34 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ujxOgaB70iQerujxOgp3aN; Fri, 15 Feb 2019 14:19:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xK8aAubc97jpKVNZW/6QoyMy8qZG1rUOLO4wERnuKt8=; b=S58TCxZa040XamWksHjfgBTapq D1VFeYp6JblA96JE9PIWvaMYP+VPfPfLrp0GMTaQpLIxaKx79NmwY7yEVyW/bleRRGuBnBPIg5i19 8hNaNOM8CfNHihO7pT1XeRPz2; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:46974 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gujxN-0036JX-OY; Fri, 15 Feb 2019 14:19:33 -0600 From: Tom Tromey To: Pedro Alves Cc: Kevin Buettner , gdb-patches@sourceware.org, Saagar Jha Subject: Re: [PATCH] Prevent overflow in rl_set_screen_size References: <20190214185254.15369a0a@f29-4.lan> <9e42397a-e3a5-0296-d239-70f4c7c0d215@redhat.com> Date: Fri, 15 Feb 2019 20:19:00 -0000 In-Reply-To: <9e42397a-e3a5-0296-d239-70f4c7c0d215@redhat.com> (Pedro Alves's message of "Fri, 15 Feb 2019 09:39:49 +0000") Message-ID: <87wom0yfcb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00256.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> so if the function takes int parameters without specifying an upper bound, it Pedro> seems like a readline bug to me to not consider large numbers. True, though it doesn't hurt to also check in gdb. What's funny is that readline *does* check for negative values: if (rows > 0) _rl_screenheight = rows; .. etc .. So gdb's approach: if (rows <= 0) rows = INT_MAX; ... actively works around the existing checks in readline. Tom