From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, KONRAD Frederic <konrad@adacore.com>
Subject: Re: [RFA] (riscv/ada) fix error when calling functions with range argument
Date: Tue, 12 Feb 2019 16:54:00 -0000 [thread overview]
Message-ID: <87wom56j7u.fsf@tromey.com> (raw)
In-Reply-To: <1549805906-1627-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Sun, 10 Feb 2019 08:38:26 -0500")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> gdb/ChangeLog:
Joel> * gdb/riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
Joel> Tested on riscv64-elf using AdaCore's testsuite.
Joel> OK to apply?
I don't have any issue with this, but I do wonder if
riscv_type_alignment can be removed and/or simplified in favor
type_align and the gdbarch method.
I see several ports have this issue. type_align should be preferred,
IMO, because it respects any additional alignment specified in the
DWARF. I assume there are latent bugs in function calling on various
platforms caused by this, though I haven't checked.
Tom
next prev parent reply other threads:[~2019-02-12 16:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 13:38 Joel Brobecker
2019-02-12 13:29 ` Andrew Burgess
2019-02-14 3:39 ` Joel Brobecker
2019-02-12 16:54 ` Tom Tromey [this message]
2019-02-12 21:17 ` Tom Tromey
2019-02-14 3:23 ` Joel Brobecker
2019-02-17 12:47 ` Joel Brobecker
2019-02-17 14:26 ` Tom Tromey
2019-02-17 15:09 ` Joel Brobecker
2019-02-18 23:39 ` Andrew Burgess
2019-02-19 14:16 ` Tom Tromey
2019-02-13 10:31 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wom56j7u.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=konrad@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).