From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org, Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 3/8] C++-ify ravenscar_arch_ops
Date: Mon, 11 Feb 2019 18:56:00 -0000 [thread overview]
Message-ID: <87wom6887e.fsf@tromey.com> (raw)
In-Reply-To: <2a5b8a83-725e-25d0-eca6-ccddef902d23@redhat.com> (Pedro Alves's message of "Thu, 7 Feb 2019 17:23:07 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> This turns ravenscar_arch_ops into an abstract base class and updates
>> all the places where it is used. This is an improvement because it
>> avoids any possibility of forgetting to set one of the function
>> pointers. It also makes clear that these functions aren't intended to
>> be changed dynamically.
Pedro> LGTM, though I'd probably eliminate the prepare_to_store method or
Pedro> make it not-abstract -- seems that no architecture does anything with it.
I had noticed that as well, but decided to leave it in on the theory
that maybe it is good to keep the interfaces "parallel". But, I don't
think it matters all that much, because if it is needed in the future,
it's easy enough to add it. So, I'll remove it.
Tom
next prev parent reply other threads:[~2019-02-11 18:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 14:22 [PATCH 0/8] Clean up ravenscar-thread.c Tom Tromey
2019-02-07 9:40 ` [PATCH 7/8] Make the ravenscar thread target multi-target-ready Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-07 9:40 ` [PATCH 4/8] Fix formatting in ravenscar-thread.c Tom Tromey
2019-02-07 9:40 ` [PATCH 5/8] Minor C++-ification " Tom Tromey
2019-02-07 9:40 ` [PATCH 6/8] Add push_target overload Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-07 9:40 ` [PATCH 3/8] C++-ify ravenscar_arch_ops Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-11 18:56 ` Tom Tromey [this message]
2019-02-07 9:40 ` [PATCH 8/8] Special-case wildcard requests in ravenscar-thread.c Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-09 4:41 ` Joel Brobecker
2019-02-14 13:35 ` Pedro Alves
2019-02-15 20:43 ` Tom Tromey
2019-02-15 20:39 ` Tom Tromey
2019-02-20 19:23 ` Pedro Alves
2019-02-07 9:40 ` [PATCH 2/8] Exception safety " Tom Tromey
2019-02-07 14:22 ` [PATCH 1/8] Fix some typos " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wom6887e.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).