From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] gdb/23712: Remove dw2_add_symbol_to_list
Date: Fri, 30 Nov 2018 20:58:00 -0000 [thread overview]
Message-ID: <87wooul1uv.fsf@tromey.com> (raw)
In-Reply-To: <20181109022847.32049-4-keiths@redhat.com> (Keith Seitz's message of "Thu, 8 Nov 2018 18:28:46 -0800")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Finally, we can remove dw2_add_symbol_to_list since the wrapper function
Keith> originally introduced to catch this multi-language scenario is no longer
Keith> needed. With multi-language dictionaries, we can now support adding
Keith> symbols of multiple languages, negating the need for the assertion
Keith> entirely.
Keith> This patch should now fix gdb/23712 (and symtab/23010). At least it will
Keith> if the NULL buildsym_compunit problem doesn't strike first (see gdb/23773).
Keith> gdb/ChangeLog:
Keith> PR gdb/23712
Keith> * dwarf2read.c (dw2_add_symbol_to_list): Remove.
Keith> (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
Thanks, this is ok.
Maybe the ChangeLog should mention symtab/23010?
Tom
next prev parent reply other threads:[~2018-11-30 20:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 2:28 [PATCH 1/5] gdb/23712: Introduce multidictionary's Keith Seitz
2018-11-09 2:28 ` [PATCH 4/5] gdb/23712: Remove dw2_add_symbol_to_list Keith Seitz
2018-11-30 20:58 ` Tom Tromey [this message]
2018-11-09 2:28 ` [PATCH 3/5] gdb/23712: Cleanup/Remove temporary dictionary functions Keith Seitz
2018-11-30 21:26 ` Tom Tromey
2018-11-09 2:28 ` [PATCH 2/5] gdb/23712: Use new multidictionary API Keith Seitz
2018-11-30 21:22 ` Tom Tromey
2018-11-09 2:34 ` [PATCH 5/5] gdb/23712: Test case for multidictionary Keith Seitz
2018-11-30 20:59 ` Tom Tromey
2020-06-02 12:26 ` [committed][gdb/testsuite] Fix scrolling in gdb.dwarf2/multidictionary.exp Tom de Vries
2018-12-16 17:01 ` [PATCH 1/5] gdb/23712: Introduce multidictionary's Tom Tromey
2018-12-18 17:28 ` Keith Seitz
2018-12-19 11:42 ` Richard Biener
2019-01-02 16:41 ` Tom Tromey
2019-01-10 22:10 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wooul1uv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).