From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26542 invoked by alias); 18 Sep 2018 19:16:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26273 invoked by uid 89); 18 Sep 2018 19:16:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1005, night, PRs X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 19:16:10 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 6A9D340113B17 for ; Tue, 18 Sep 2018 14:16:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2LTOg52f9aSey2LTWgVGlp; Tue, 18 Sep 2018 14:16:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5pwKSe4q7Z5ho1RLNrIoxW2wzHfhJCE6X8lw3wGHiGo=; b=U76NIG57cG2r3SDZCOe9aSAT0T gfEGc38NbyrpxikDDB4QS7VcIHEV2EmA8wTcxPjUDBtSFPoWuUfEILq59U/0zt3hZL18jjI/0JfwU /lU8N4No49IQcxSWg4mYMfV0y; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:52916 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g2LTN-002ua9-Ox; Tue, 18 Sep 2018 14:15:45 -0500 From: Tom Tromey To: Sandra Loosemore Cc: "gdb-patches\@sourceware.org" , Subject: Re: [patch] add missing gcc_target_options method for nios2 References: Date: Tue, 18 Sep 2018 19:16:00 -0000 In-Reply-To: (Sandra Loosemore's message of "Mon, 17 Sep 2018 09:22:03 -0600") Message-ID: <87worisjkv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00651.txt.bz2 >>>>> "Sandra" == Sandra Loosemore writes: Sandra> While looking at gdb.compile test failures on nios2, I found that it Sandra> was passing an invalid option to gcc, due to another missing target Sandra> method. This patch doesn't make the "compile" command work for me yet Sandra> (see PRs 23671 and 23672 that I filed last night) but it seems like Sandra> something that will be necessary to get there. OK to commit? Sandra> -Sandra Sandra> commit fce4579114f47246773caa9c68969a90794ff90d Sandra> Author: Sandra Loosemore Sandra> Date: Sun Sep 16 14:35:43 2018 -0700 Sandra> Add gcc_target_options hook for nios2. Sandra> 2018-09-16 Sandra Loosemore Sandra> gdb/ Sandra> * nios2-tdep.c (nios2_gcc_target_options): New. Sandra> (nios2_gdb_arch_init): Install new hook. Thank you. This is ok. The default gcc_target_options seems overly specific to me. Tom