From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112256 invoked by alias); 25 Jul 2018 19:17:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112245 invoked by uid 89); 25 Jul 2018 19:17:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jul 2018 19:17:05 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id D4F3B5230B0 for ; Wed, 25 Jul 2018 14:17:03 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iPHTf8PXWRPojiPHTff0PF; Wed, 25 Jul 2018 14:17:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1SaJLIdHEs+tz5+Ng3MWYCgwFtVSHF7ElXBikQ4PvT4=; b=pbC6Hx9iltYB+5wRVEnaw8aAqP Yeo1D1TIO/kJOAIO4q4p41PNBZPNgIkrzkl2J7LdeUFPvAvRid+DgyPqgzEfouGFQls8GC7b3zpdW ojdzDrGfda3CfCMOzrP/NTsoT; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:36554 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fiPHT-003JPb-Kl; Wed, 25 Jul 2018 14:17:03 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/breakpoints] Fix sigsegv in info prog at exec catchpoint References: <20180720141359.qycrai5coi5rdyag@delia> Date: Wed, 25 Jul 2018 19:17:00 -0000 In-Reply-To: <20180720141359.qycrai5coi5rdyag@delia> (Tom de Vries's message of "Fri, 20 Jul 2018 16:14:00 +0200") Message-ID: <87wotjyvkh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00705.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> The patch fixes the segfault by returning an error in info_program_command Tom> if get_last_target_status returns minus_one_ptid. Tom> The test-case is non-standard, because the standard approach runs into Tom> PR23020, a problem with gdb going to the background. Is it possible to fix this part first? Otherwise it seems to me that the test case has some issues. Also, is the bug dependent on -batch? This wasn't clear to me, but I guess if it is then the approach to the test case makes more sense. Tom> PR breakpoints/23366 Tom> * infcmd.c (info_program_command): Handle ptid == minus_one_ptid. This part looks ok to me. Tom> +if { ![file exists /bin/bash] } { ... Tom> +if { ![file exists /bin/ls] } { ... Tom> + catch {exec /bin/bash -c "$GDB $FLAGS"} catchlog I think this sort of thing can't be done when doing remote host testing, so some sort of check is needed for that. I don't remember any more exactly how this is done but there should be other examples in the tree. Tom> +if { ![file exists /bin/bash] } { Tom> + unsupported "no bash" Tom> +} Also there has to be a "return" after the "unsupported"; unsupported just logs a message and without the return, the rest of the test will still be run. Tom