From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124003 invoked by alias); 16 Jul 2018 15:35:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123989 invoked by uid 89); 16 Jul 2018 15:35:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=hold, wondered X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 15:35:48 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 1A2154A8C2F for ; Mon, 16 Jul 2018 10:35:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id f5XPftHUOSjJAf5XPfgXI1; Mon, 16 Jul 2018 10:35:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7injEpNLAFKISR5PZFNh7hCndUVkL71QozsqJUs2aSE=; b=F+7vQ9N0xMyOdtD0DR+vjjqYg7 zEVMs4Favp1FRrJsgXOh+Fi0mfCUtHz9D7C5sttYRd5+QggORB7emDeXVjqRflXc783LwYg3JYDKg XnQez7dBPvf7TkYq1ENrbIveA; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:38228 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ff5XO-000DhC-RS; Mon, 16 Jul 2018 10:35:46 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA 01/13] Simple unused variable removals References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-2-tom@tromey.com> <87b519fc-318a-84aa-7ced-aea354f059fb@simark.ca> <87in5i9ej4.fsf@tromey.com> <51240093-05e2-7294-7ffd-a893c9147b53@redhat.com> Date: Mon, 16 Jul 2018 15:35:00 -0000 In-Reply-To: <51240093-05e2-7294-7ffd-a893c9147b53@redhat.com> (Pedro Alves's message of "Mon, 16 Jul 2018 14:33:26 +0100") Message-ID: <87wotv6vn2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00485.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Simon> - CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4, Simon> - 4, byte_order); >> Simon> I wondered this was a bug (should that variable really be used), but I Simon> wouldn't know without some quite extensive research... so all-in-all, LGTM. >> >> Yes, this one was on the bubble and I almost put it in its own patch... >> I can't recall offhand if there were others like this. Pedro> I skimmed the patch and it looks good to me to, and, that bit Pedro> also gave me pause. I was wondering whether we should replace Pedro> it with a comment, saying that we're skipping 4 bytes which hold Pedro> the entry's size. That might save someone some time in case the size Pedro> turns out to be needed. (I have no idea where the structure being Pedro> extracted is documented, for example.) I've split this into a separate patch and added a comment. Tom