From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93028 invoked by alias); 2 Jul 2018 14:58:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93005 invoked by uid 89); 2 Jul 2018 14:58:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=About, effort, rfa, RFA X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Jul 2018 14:58:28 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 3A474206A7 for ; Mon, 2 Jul 2018 09:58:27 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id a0Hbft6vgaSeya0HbfXvLB; Mon, 02 Jul 2018 09:58:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JKxtWcKGckKooPt6sM2zIKpOXJUJy7/aUAOowHJ++Fs=; b=UyWFmTXKsEDY1O8aWpaFJtfGpb InMDnzY+HUpSnrHCzetINk4KezdsXMMdP1LkiGWUz+R5tRLZO2N81+xtmaAnv6/sgOgRy4T0WXPaN wtSoUG1BozYzdiGzijgEtANF3; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44194 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fa0Ha-0031rw-WC; Mon, 02 Jul 2018 09:58:27 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [RFA] Make macOS build warning-free References: <20180629165453.22888-1-tom@tromey.com> Date: Mon, 02 Jul 2018 14:58:00 -0000 In-Reply-To: (Simon Marchi's message of "Fri, 29 Jun 2018 17:34:40 -0400") Message-ID: <87woudofal.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00010.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> About the gettext / non-literal warning, this is the patch I carry. I tried Simon> to dig up why gettext doesn't define _INTL_MAY_RETURN_STRING_ARG for __APPLE_CC__ Simon> but couldn't find it. My guess is that in a distant past, the Apple compiler Simon> did not know about that attribute. You need another change to get rid of the warning Simon> though. Thanks. I looked into this a little more. It seems like a huge effort, because, first, upstream doesn't have this fix; and second, it seems like it would have to be imported into gcc first. Fixing this upstream would probably require the same thing for other functions, not just gettext. I think in the meantime I'll just --disable-nls. Perhaps you wouldn't mind approving the symfile.c change in isolation. Tom