From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8798 invoked by alias); 31 Jul 2017 22:10:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8779 invoked by uid 89); 31 Jul 2017 22:10:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=misread X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 31 Jul 2017 22:10:20 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id E10CE17708F for ; Mon, 31 Jul 2017 16:10:18 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id raAF1v00d2f2jeq01aAJXm; Mon, 31 Jul 2017 16:10:18 -0600 X-Authority-Analysis: v=2.2 cv=Aoae5K1P c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=G3gG6ho9WtcA:10 a=VnNF1IyMAAAA:8 a=8o17y1tE2Tc1lcYO7rsA:9 Received: from 174-29-39-24.hlrn.qwest.net ([174.29.39.24]:46830 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dcItD-001FFX-Fd; Mon, 31 Jul 2017 16:10:15 -0600 From: Tom Tromey To: Andreas Arnez Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [pushed] s390-vregs.exp: Fix Tcl error after non-zero-pad patch References: Date: Mon, 31 Jul 2017 22:10:00 -0000 In-Reply-To: (Andreas Arnez's message of "Mon, 24 Jul 2017 18:38:31 +0200") Message-ID: <87wp6o8dh8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dcItD-001FFX-Fd X-Source-Sender: 174-29-39-24.hlrn.qwest.net (bapiya) [174.29.39.24]:46830 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-07/txt/msg00462.txt.bz2 >>>>> "Andreas" == Andreas Arnez writes: Andreas> This is a regression, caused by commit 30a254669b16b8 -- "Don't always Andreas> zero pad in print_*_chars". That patch introduced a new procedure Andreas> "hex128" for formatting a 128-bit value as hex, but it accidentally moved Andreas> the calculation of the 128-bit value into that new procedure as well Andreas> instead of leaving it in the original context. This is fixed. Thanks. I'm sorry about that. I try not to make mistakes like this by running all my changes through the buildbot, but either it didn't report this, or I misread the results. Tom