From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter
Date: Fri, 14 Jul 2017 18:56:00 -0000 [thread overview]
Message-ID: <87wp7au9th.fsf@pokyo> (raw)
In-Reply-To: <5aa8225f-70d1-2e69-9280-ca527b2ea981@redhat.com> (Pedro Alves's message of "Tue, 27 Jun 2017 19:37:01 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Can you expand on the need for the PRINT_MORE_FRAMES flag and
Pedro> having it based on from_tty? I assume that your first made
Pedro> the printing unconditional, but then for some reason decided
Pedro> against it?
I think my reason was just to have it parallel the no-frame-filter code
in stack.c:
/* If we've stopped before the end, mention that. */
if (fi && from_tty)
printf_filtered (_("(More stack frames follow...)\n"));
I don't know why this code is conditional on from_tty, but that seemed
like a separate decision.
Tom
next prev parent reply other threads:[~2017-07-14 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 16:04 Tom Tromey
2017-04-25 18:27 ` Sergio Durigan Junior
2017-04-26 0:17 ` Tom Tromey
2017-05-29 17:21 ` Tom Tromey
2017-09-30 20:38 ` Tom Tromey
2018-02-12 16:45 ` Tom Tromey
2018-02-24 17:09 ` Tom Tromey
2018-02-25 18:29 ` Simon Marchi
2018-02-26 16:35 ` Tom Tromey
2017-05-31 15:19 ` Phil Muldoon
2017-06-27 18:37 ` Pedro Alves
2017-07-14 18:56 ` Tom Tromey [this message]
2017-08-14 14:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp7au9th.fsf@pokyo \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).