From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116948 invoked by alias); 14 Jul 2017 18:56:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116914 invoked by uid 89); 14 Jul 2017 18:56:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy5.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 18:56:18 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id B05A5140442 for ; Fri, 14 Jul 2017 12:56:17 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id kiwE1v00a2f2jeq01iwHYd; Fri, 14 Jul 2017 12:56:17 -0600 X-Authority-Analysis: v=2.2 cv=UM2tJGXy c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=G3gG6ho9WtcA:10 a=20KFwNOVAAAA:8 a=fnsCRAJlNsM8RJA4rJIA:9 Received: from 174-29-39-24.hlrn.qwest.net ([174.29.39.24]:50936 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dW5l8-002zTM-F6; Fri, 14 Jul 2017 12:56:14 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter References: <20170423160446.17062-1-tom@tromey.com> <5aa8225f-70d1-2e69-9280-ca527b2ea981@redhat.com> Date: Fri, 14 Jul 2017 18:56:00 -0000 In-Reply-To: <5aa8225f-70d1-2e69-9280-ca527b2ea981@redhat.com> (Pedro Alves's message of "Tue, 27 Jun 2017 19:37:01 +0100") Message-ID: <87wp7au9th.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dW5l8-002zTM-F6 X-Source-Sender: 174-29-39-24.hlrn.qwest.net (pokyo) [174.29.39.24]:50936 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-07/txt/msg00200.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Can you expand on the need for the PRINT_MORE_FRAMES flag and Pedro> having it based on from_tty? I assume that your first made Pedro> the printing unconditional, but then for some reason decided Pedro> against it? I think my reason was just to have it parallel the no-frame-filter code in stack.c: /* If we've stopped before the end, mention that. */ if (fi && from_tty) printf_filtered (_("(More stack frames follow...)\n")); I don't know why this code is conditional on from_tty, but that seemed like a separate decision. Tom