From: Tom Tromey <tom@tromey.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: qiyaoltc@gmail.com (Yao Qi),
gdb-patches@sourceware.org (gdb-patches@sourceware.org),
tom@tromey.com (Tom Tromey)
Subject: Re: set_value_component_location in apply_val_pretty_printer
Date: Mon, 31 Oct 2016 03:07:00 -0000 [thread overview]
Message-ID: <87wpgpusiy.fsf@tromey.com> (raw)
In-Reply-To: <20161028185834.0145C10B927@oc8523832656.ibm.com> (Ulrich Weigand's message of "Fri, 28 Oct 2016 20:58:33 +0200 (CEST)")
>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
>> It was added by Tom in
>> https://sourceware.org/ml/gdb-patches/2010-06/msg00132.html
>> There wasn't much information in email and ChangeLog.
What Ulrich wrote is better than anything I was likely to write.
Ulrich> That's why all the val_print routines not just receive the
Ulrich> original value object (which remains unchanged even while
Ulrich> recursing through subobjects), but also an idenfication of
Ulrich> the subobject that is to be processed: this is a pair of
Ulrich> offset and type, and means, the subobject of type "type"
Ulrich> starting at offset "offset" within the larger object.
I've thought for a long time that val_print should just be removed, and
only full values should be passed around.
Tom
next prev parent reply other threads:[~2016-10-31 3:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 14:18 Yao Qi
2016-10-28 18:58 ` Ulrich Weigand
2016-10-31 3:07 ` Tom Tromey [this message]
2016-11-14 12:52 ` Yao Qi
2016-11-14 16:38 ` Ulrich Weigand
2016-11-21 14:14 ` Yao Qi
2016-11-21 18:23 ` Yao Qi
2016-11-21 20:37 ` Yao Qi
2016-11-22 9:00 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpgpusiy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).