From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 482 invoked by alias); 20 Nov 2014 03:08:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 457 invoked by uid 89); 20 Nov 2014 03:08:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 20 Nov 2014 03:08:38 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAK38YgQ028033 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 19 Nov 2014 22:08:35 -0500 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAK38YQE017126 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 19 Nov 2014 22:08:34 -0500 From: Sergio Durigan Junior To: Gabriel Krisman Bertazi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Create syscall groups for x86_64. References: <1414956944-8856-1-git-send-email-gabriel@krisman.be> <1414956944-8856-4-git-send-email-gabriel@krisman.be> <87ppcp75hd.fsf@redhat.com> <87r3wyoc5q.fsf@krisman.be> X-URL: http://blog.sergiodj.net Date: Thu, 20 Nov 2014 03:08:00 -0000 In-Reply-To: <87r3wyoc5q.fsf@krisman.be> (Gabriel Krisman Bertazi's message of "Thu, 20 Nov 2014 00:09:53 -0200") Message-ID: <87wq6qsh59.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00450.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 2132 On Wednesday, November 19 2014, Gabriel Krisman Bertazi wrote: > Sergio Durigan Junior writes: > > Sergio, > > Thank you for your review. I applied your suggestions and I will send > the updated patches to this list in a few moments. Thanks! >> On Sunday, November 02 2014, Gabriel Krisman Bertazi wrote: >> >>> This commit introduces the following syscall groups for the x86_64 >>> architecture: memory, ipc, process, descriptor, signal and file. >>> >>> Please note that the sorting of the syscalls among these several groups >>> follows the same structure used in strace. >>> >>> This also introduces tests for catching groups of syscalls on the x86_64 >>> architecture. >> >> I guess I said that before, but just in case I didn't: I would prefer if >> this patch already updated the other architectures as well. IIUC you >> are planning to do that in another series of patches, but it would be >> good if you did everything at once, I think. However, I will not oppose >> if you decide to touch only on x86_64 for now. > > Updating the syscall files by hand is quite error-prone and requires > lots of typing. Should we bring PR 14276 to the table, it would also > require extra work to update the groups later. Yeah, I am aware of that :-/. > A few weeks ago, you and I talked about writing a script to fix PR14276. > What I want to do is to save me some typing now and update the other > architectures only after we have such script to generate the syscall > files, so we can use it to also generate the group information > automatically. What do you think? Is that ok for you? Heh, since you asked :-P... My opinion is that writing this script could take some time, and I am not counting on it be to ready soon, unfortunately. That being said, I also don't think we should let the perfect be the enemy of the good (I think Pedro said that once, and I liked the phrase). Therefore, I am OK with your patch as is, provided we don't take too long to start working on this script :-). Thanks, --=20 Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/ --=-=-= Content-Type: application/pgp-signature Content-length: 818 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUbVsyAAoJENDrdihl/F42p+wP/0A1uiqZ3KOa2x2/e4RQemO1 RnS78TWPRtYMtsY02trwYUFPjFB6Z1cyHCKPCMFS/miDEX8KEa4CNyYlhtBReAEg 7BSAfbbyRSPKh9VmcHdtgoKjJpgY4jc/T3WuVg/Ez165EEfUO7b+GwPqcjM344l0 cnSb1ay+oOea3XDYqR8LJ5hTCUOUu8T+vVncKUGULRMtcj5R6fhsvUDBFhMoF34k YFPSby1907M0LvdIHDLepstavi0U+q0IXP1vp3bXwO1/GDaObIYrO0BLv+YDI8sQ UvTg991TufxZgT2gGjzZpNKGMo/g/oNZHz0BFhZFpNVdGM9+Nxiy+4tDOixgPyN9 10rPOakUjNvWN3M2II1wPOdIezGWM0xRabfPths2IDR4oMAKNNvCEiJYyyWCOVIP y2h2EdkZRBkzvbhyV1d1YenjifceWOaOAkmB3QzYjhO/40i7yRQ7Xdt9iY7pOwiP wUG3HaQIeNzX1y9sCUky878WUDPAMsO5tZ6wXJnsc7G/a4ZUUgpuNC8SX6pXrCYZ IqcxV7oGduhB2LGXvM/1Tyi3FBvYplGtyOdznl6hgWG4VtQzAMvIkuVZZ+F1g5o7 h8U2w2q1ueZUYLXGK1ST4BzTBZgoODJStrWhhR2LHLptVKGoJxguDnLmUVjII4JX uRKyZvhB1/JimHpXYvbW =5xsL -----END PGP SIGNATURE----- --=-=-=--