From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18950 invoked by alias); 7 Nov 2013 20:42:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18939 invoked by uid 89); 7 Nov 2013 20:42:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPAM_SUBJECT,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2013 20:42:53 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA7KgiHB006156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Nov 2013 15:42:45 -0500 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rA7Kgh7Y031798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 7 Nov 2013 15:42:44 -0500 From: Tom Tromey To: Sanimir Agovic Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/10] vla: update type from newly created value References: <1382366424-21010-1-git-send-email-sanimir.agovic@intel.com> <1382366424-21010-7-git-send-email-sanimir.agovic@intel.com> Date: Thu, 07 Nov 2013 20:56:00 -0000 In-Reply-To: <1382366424-21010-7-git-send-email-sanimir.agovic@intel.com> (Sanimir Agovic's message of "Mon, 21 Oct 2013 16:40:20 +0200") Message-ID: <87wqkkt03g.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00208.txt.bz2 >>>>> "Sanimir" == Sanimir Agovic writes: Sanimir> Constructing a value based on a type and address might change Sanimir> the type of the newly constructed value. Thus re-fetch type via Sanimir> value_type to ensure we have the correct type at hand. Sanimir> 2013-10-18 Sanimir Agovic Sanimir> Keven Boell Sanimir> * valops.c (value_ind): Re-fetch type from value. Sanimir> * value.c (coerce_ref): Re-fetch type from value. This is fine by itself; however, I wonder whether there are other calls that require fixing. Did you check through the rest of the code? Tom