Re: Optionally print source code to gdb console window

[Tom Tromey <tom@tromey.com>]

> The first is that the output looks like this in the suggested case,
> (gdb) n
> 43      in test_main.cpp

Yeah, that's no good.

> My personal opinion is that gdb shouldn't print code to the console in mi mode
> or in new-ui mode. However, there were some people from eclipse a few years
> ago that said they disagreed and that gdb should behave identical in new-ui
> mode and not in new-ui mode, so i've attempted to make an option.

Ok.

> Can you give me some pointers on how the implementation should change?

The new flag shouldn't be in value_print_options.  That struct is only
for things affecting value-printing.

Perhaps 'set source open' could be extended to have a new value.  Or
perhaps some other 'set source' sub-option could be made.  I'm afraid
that normally we bikeshed option names a bit.

> I should also ask, is an option even necessary?
> I think if we remove the source printing from the console when in new-ui mode
> or in mi-mode it would make the most sense. After all, there is a front end displaying
> this information, no?

I personally don't have much stake in it, but it seems to me that if the
Eclipse folks and/or the new-ui implementers already discussed it, then
an option is necessary.

Tom