From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 3328F3858D35 for ; Thu, 7 Mar 2024 20:19:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3328F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3328F3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::530 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709842774; cv=none; b=RnkkRab7CATmLQFNgZElBcmP2iwGcaSk2UBkmDJP7qaoSI54M8blofqDqXUbUFMtd7GveLdrERSRmayJeWoFmLmGIqXVnt/noO0ptwxJEgFRVaBEaOy9jtws8z2pFzoJKx26hv5G1gPiX7Qi4Z7Qtm/0Yc3aeOA3lqnfA6gvUEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709842774; c=relaxed/simple; bh=YcYTyhNbhOJKBje8VpNUW6x7ZYdMHCWOiCrq7Xi8fvo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TcxfAed9yXNcsUABglqOO8q98unWSBGwiAb/ZuiEV6nJuNL9g8//cywPJ418t+DmDHpvHlU2bR03s60q7fRoSBU3fh23ubajofUM5e4QU3kzzhOy/xZpWwPz2NLasUSDWawzML3DEp1eE8tNWfF4dcq7u1vVjPslUlVCuWlScVY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-5bdbe2de25fso1071280a12.3 for ; Thu, 07 Mar 2024 12:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709842771; x=1710447571; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=YcYTyhNbhOJKBje8VpNUW6x7ZYdMHCWOiCrq7Xi8fvo=; b=h5ngeZA2SRThgxGH9twc/JjHU2nIWbCYjqADg7Ge0fgpJXQ6NYY0Qq9AhyZTeUV46w qo+Td85YbQ1b+gK3cJU9wcpqsMZ/MujiLpKxtkiTf4zjFLmBLKb0eZcJ7S4kFZLnSfAe Je9OYM2YuVDq+2Jlylqwz7jsOfZJp7szzlaHUuv+Wkdulmd+i4qljTLInIr/m6O9PW07 0+/vx3wrJjA3/j9Pbxo5N6AABOfLnhFiNL96dRbiL8dVWHZzbanObxKDZj4lgo8ihiX5 5YVDWbYOnQ0kr9hedE0MBWu+QnOfyEqKnYjWi+d6khqM9s80YQBOlFuHls0sqBhe9W/K E6Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709842771; x=1710447571; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YcYTyhNbhOJKBje8VpNUW6x7ZYdMHCWOiCrq7Xi8fvo=; b=YTQGr2+ZB9SpkEIwNuCNXHcko3X2f6iPe3RSuTmPIcYNNDYNTOYud4TBaQ64b9Zmr3 hkB4HMuW+jZjqSkzP4HTVEI7vX4LUEItCWSenepLJ0T3MyShb7bL4hG+ZKLNr2QDG31z DMFR2pm8KjtsTuM572O47neN4NBiVzS+kpKTaG02K8gLJi4/YBoSn/FzmbC8zLaLbDkY dNY2PVjFnWDBOVUlxXP+yhO+X7OZlKmyc48h0dnTCsoN+Pm5cunCJbjmjX8EFYGvWKmo 0nHPeXKZWSWxt9nUztZBtNr3I6vqTpT7KdeG94tfkIssPV9HDEp24DXR+CyoIkXm7vDr 3DsQ== X-Forwarded-Encrypted: i=1; AJvYcCUb+uZED0Dc8oYaAKAFf4060LfBgcJnZrvtgarEeOdh+2rBr/RukD+IF+KQkBWC5nL3F2QI/FMDy/bed996vz1H27QJh7F+1KhepA== X-Gm-Message-State: AOJu0YyeMu5LYck71nSFlkGDrqmSjZXGDVcrxHEGZjRzQqgrL5XE02DL XqDvJOQm5CW42Atuj79R/CNDFB72RraT+RZuQao4NVONHP7HKn0L7M+gFYL58nZqo8sCEOCY5vy u X-Google-Smtp-Source: AGHT+IGIfOPCfAhxRQB69rRX+irin8xwcSKMNYZzjEoB0myy/9fK4d2v1pMXPY9xgCC/ocWBxTxWog== X-Received: by 2002:a17:903:24c:b0:1da:eed:f25b with SMTP id j12-20020a170903024c00b001da0eedf25bmr10991323plh.46.1709842771003; Thu, 07 Mar 2024 12:19:31 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:4fc9:febd:d8c9:52b]) by smtp.gmail.com with ESMTPSA id f10-20020a170902684a00b001dbf5048712sm391081pln.93.2024.03.07.12.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 12:19:30 -0800 (PST) From: Thiago Jung Bauermann To: Luis Machado Cc: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] [gdb/tdep] Fix gdb.base/watchpoint-unaligned.exp on aarch64 In-Reply-To: (Luis Machado's message of "Thu, 7 Mar 2024 10:50:33 +0000") References: <20240220205425.13587-1-tdevries@suse.de> User-Agent: mu4e 1.12.0; emacs 29.1 Date: Thu, 07 Mar 2024 17:19:27 -0300 Message-ID: <87y1atg5gw.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Luis Machado writes: > Raising the alignment enforcement means we will cover a bigger range of addresses, > potentially covering our target watchpoint/trap address, > but I'm afraid it also means we will raise the potential for false positives, if > watchpoints are placed within the alignment range. > > Furthermore, we are not limited to 16-byte accesses. For SVE and SME we may be looking at > even bigger accesses. And, more generally, the memset/memcpy > instructions (not yet widely used) can potentially access arbitrary amounts of memory. So > tweaking the alignment is only a focused fix towards the most often > used instructions and access sizes at the moment. > The more general problem of not being able to tell which particular watchpoint caused the > trap remains. > > How does the above fix behave on the overall testsuite in terms of watchpoint tests? According to the Linaro CI, there's no impact: https://ci.linaro.org/job/tcwg_gdb_check--master-aarch64-precommit/1749/artifact/artifacts/artifacts.precommit/notify/mail-body.txt I'm a bit surprised that there were no progressions from this patch. The job ran on a Mt. Jade machine. -- Thiago