From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 41C0D3858CDA for ; Tue, 30 Jan 2024 17:18:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41C0D3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41C0D3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706635132; cv=none; b=kOfmjktmyKs/vdNEw9GJemX3Vjvi7kJ8/bxh0Pd+Na8X+usQ+JvmDjNbFY8wEahXI2RgLpCVTrfBayEWrqiaCUy4jSTrmxkDhK/NbNO3tdMyoyLKppcokQ1pIX7yDPcYV7djKdBTMS5wXtIqtX6fO23VOuAborRhkkb2o9PXd5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706635132; c=relaxed/simple; bh=TdSR86TQyvwAzROCIKzYqsUS3MjJ7ThZgyf/oX9G1iM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SFhIq5JLRT/yEzZdIjPraCGHy4ijJdBevlSnQuJYIV8KdGOGrdFUNPtEfUHGlJqgYupeXaXWeaKNgDlrKeVXwxODXeM7rDCGOTBg4Y6aQu9g7BevmrC6XNNeDBq6J6X8WBCA61Nu41r9725M874I6Wh0jJbM2Tq2hBLpmxXkUBQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-3638e3ace68so2973375ab.2 for ; Tue, 30 Jan 2024 09:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1706635129; x=1707239929; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6PAMwb4tO5FE/2lHxWV0dPqFtHpOQbt4ttoQEtlP31A=; b=g5627RgQyEOs4C0upLCQ8GfJleGSb4bn7vGv5w8xNFbHwO9zOadtQiiMN3KnG1AeAa TSiW7joKoeeGMgF7geR9maapOAGn0jpJBMP8WfdUHa5QK+j2IHEkwpSDuOZctE9endRz 2+6/yX7LLB099s3JI0cxHVQWJUc4VuLTQ+vrbTPslVX3rhGRe8TDn3XeoncAtXvmQDna vNswYTMObd+9gzHO7S/XT81cf8nUpWq9TQIBcErehP4lIBVaKAm3TLf3cm5MYjQBwFoA a0GmW5BDbkFrDjreHQ/nRa1tcnohiOSfWH+jpjBSHABpqPBZpjJt1YfVObxuZ4fl14VN DOZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706635129; x=1707239929; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6PAMwb4tO5FE/2lHxWV0dPqFtHpOQbt4ttoQEtlP31A=; b=u4xsU/bZK7v5g281JlF8vZTjFndFV6HSy808Mcgxqw7y3UKCAoSiowG+pIuW3fTf4D zbdEcXOSTH4RQmfYJvjs6kNgEHAK/Tvdt1MQKTYIyauBiMHNf+0D2sEHF+X8BGFa6Zz8 Mx9pgeRuhND1OruGZ7UYzpH+Oj8eSlov/klsVOcW8EdRWhbCTJTFFFxQxpoCBfQImlbr z7pLyYZw8UJpynYuADnV34aQYRk/G0O2mxaM/+Y3Umen6H9tdnsu+x5uVRy+DCtf2aqD uDruJsy/iiMGolnAgE7qEY7/z+RVMPYaS7RxTlvBNohGS8QNTIRYV80qNli0GaA5gDyL OBLQ== X-Gm-Message-State: AOJu0YxDeaWtK8Ghuhn5B2UDtTBn8blgbYLRrQj53X3Zu5J/j6sF5V0c BTXMKBwLhTVO/MopWzGS/smKW+yj6dTlnCCI6dmbTxLceN987mYG3tqjki7xG4TQDoiCjBI6lkM = X-Google-Smtp-Source: AGHT+IEylaWTjyO2Lkh4Iahr3gep+9FMmM64/Hc38fbcoDrZgZvOA+Wl5Scw1/qGKPuLjvjDNQY1Eg== X-Received: by 2002:a05:6e02:1d9c:b0:363:856f:bcf0 with SMTP id h28-20020a056e021d9c00b00363856fbcf0mr5602445ila.21.1706635129267; Tue, 30 Jan 2024 09:18:49 -0800 (PST) Received: from murgatroyd (97-122-68-157.hlrn.qwest.net. [97.122.68.157]) by smtp.gmail.com with ESMTPSA id cb19-20020a056e02319300b0036385ee29c7sm1114101ilb.59.2024.01.30.09.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 09:18:48 -0800 (PST) From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Really fix Windows gdbserver segment registers References: <20240124150044.2881846-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 30 Jan 2024 10:18:48 -0700 In-Reply-To: (John Baldwin's message of "Tue, 30 Jan 2024 08:50:53 -0800") Message-ID: <87y1c6g2o7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "John" == John Baldwin writes: John> LGTM as far as I understand it. John> Reviewed-by: John Baldwin Thank you. I'm going to check this in. Also, FWIW, it's been in nightly testing internally at AdaCore for a while now. Tom