From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id B9EBA38582A4 for ; Wed, 24 Jan 2024 15:31:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9EBA38582A4 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9EBA38582A4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706110279; cv=none; b=X5w6DKKckq83F/UTW+iW63rVPkQ0CZFh2v5TTG/jgmQ4TC5+yimQ1dXUV7y1I57SoEBmaXLtVbRx4CGo56ApQYXw0aGGs8786dO7ggNT+AYYQmgclpJMRM0nfR2lZZMwcfEw8LM9MZR44s3aPFLznYTdCyUQmStb7RHVUMB4L/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706110279; c=relaxed/simple; bh=1MEit1oK7zoSqkv1flAiAmNvQ4GUvQBpf7eq7htbv10=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ExezoUtqCqtft9L5RhT0dnaWpZcbTz5h1vfUoSCwsQ/lfWfpxZpHtcw1giguN2CS7Q1UGzZjswLNpn26iYvB1Fi0uf18vtnvGpfwZpHTc+4BUaCEdReMxyDsVC1RAxIwZeSIl5sd89CaToDHpzHINPuUsYXSp9iUehYIQJQE+L8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7bf2ecba260so200119239f.2 for ; Wed, 24 Jan 2024 07:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1706110276; x=1706715076; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6jtE4dalvNRX79/XnCWDxUsJFAe+IsNIbdAoqdUzDDs=; b=EGGhm79Xcu70AtTWlHZUZrIwHk3u9NQTeKISId9+bBrPq9kTD+6admMT9BDD0tL07B bHc1g9H84yMgKaP3bleMnMD3WmflRdCC6hwtJIujtB4LxFF0uikFNGNK66fEvKxFkbpz RRDC3WuTS9vxZiw1Ovnypr7zc3fH8NEqS1NdgeDtDPY4eyhGulQThyPWBb8jm/sHbhgK jzP/Xr64Ap+ccg30L9hxzQ7L02a+cTux4sY0RQUe0AJpkCOpqXnTrlkHSxxbzlkRU52J ZyM3zkEZASHtIs8djZ4nG9gSYT3RFo/0GOO7wX4/FLRWocglh1tSq7XdZJiNts9ELTcQ G/cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706110276; x=1706715076; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6jtE4dalvNRX79/XnCWDxUsJFAe+IsNIbdAoqdUzDDs=; b=tB8r1NeI8oDw+XAVSlUAcB7AX78lHEYqkPFsEYQNhMy1o5EZBRuX+44XBcAOigmNL9 HS7Teocup27ScDRCY7nVVV01fDJIUmXGxU9dk4d4/ve4Yqg9hde7QJ31c1pWI/MjQQX+ FrJbXDhRryFU5MLSwgBWn1p55z13PmbUHYn9LSf0Npxtusi/9pIKXHl1JQO1ZjjoIPhc 2mBnOA4JlUKBBym8ZbKKDjczx0itVoxtESaIDmem+gqHW/cVIfg/zLr904l1k22xMts6 DfGIHNAi0FwB4nysCn4YaSFkSnujOD+SA/O4hwcC9EqefxNm1CmPoKIpMvqDfdngSTtP MbwQ== X-Gm-Message-State: AOJu0YzVS6aV9SzqVeNMSGgors4ktuCTr6U+umxSa4sHOXWawHXl9ezX 3NzBRBp9kZHofO00wP86ouwGIaTs+tJvDfgKG+X747XKyYTtB5ALSOhal1cIPJ7V0wbU00badtA = X-Google-Smtp-Source: AGHT+IGISD9tKfsss4CmgowAW77clr2utsooRe7q80yaSzOQqvBxjhqjTIwvsqAjsRngTPxkbSpMnA== X-Received: by 2002:a5d:9318:0:b0:7be:f220:9c46 with SMTP id l24-20020a5d9318000000b007bef2209c46mr2007450ion.41.1706110275994; Wed, 24 Jan 2024 07:31:15 -0800 (PST) Received: from murgatroyd (97-122-68-157.hlrn.qwest.net. [97.122.68.157]) by smtp.gmail.com with ESMTPSA id l13-20020a02cd8d000000b0046e578ed0aasm4095236jap.96.2024.01.24.07.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 07:31:15 -0800 (PST) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Emit stopped event for DAP attach request References: <20240117162014.2927548-1-tromey@adacore.com> X-Attribution: Tom Date: Wed, 24 Jan 2024 08:31:13 -0700 In-Reply-To: <20240117162014.2927548-1-tromey@adacore.com> (Tom Tromey's message of "Wed, 17 Jan 2024 09:20:14 -0700") Message-ID: <87y1ceiw8u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> In an earlier patch, I wrote: Tom> ... It also adds some machinery so that attach stops can be Tom> suppressed, which I think is the right thing to do. Tom> However, after some discussions here at AdaCore, I now believe this to Tom> be incorrect -- while DAP says that expected "continue" events should Tom> be suppressed, there is no corresponding language for expected "stop" Tom> events, and indeed "stop" events explicitly mention cases like "step". Tom> This patch arranges for the stop event to be emitted again. I'm checking this in. Tom