From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 816C43858C2A for ; Sat, 20 Jan 2024 17:05:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 816C43858C2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 816C43858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705770331; cv=none; b=Qxa0e/BqSTRkA31tt38Qr1MNTlvEHVUkKwa1kTiIs1pPmK2eeEwAfY7+JIY8TWqUQiOupMba6bPvkDH1ZHev7NpM0Oc1gbg9EH0tsMsCIVgIRHcs7NvRXHHME8vWgr8yO7g97GPjbieWQlMyTYGmMWFMFrlYuSKyuig+KSvF5Vo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705770331; c=relaxed/simple; bh=HZW2Lkf26dGb6eW3THeR/1sGc3R4oDtHb3KzF4vfGSM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bYRXncgv/mqdcryFdgfxYKIqLACGYrpDlje0UzT/vTmCpPHJVCwS2u5NN2YzqCrzhfFKilmwa11j6alYt85AUpEdgd0XhctmtA2CkWo/Qnh7EMdGHGSRR4nDkd3Gpig8zK5oDt8vCbvu68CK+WrjvHQ8FLnvQPNRliGXsUgA2q8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id Qu6HrDO4NAxAkREmvrh8Wm; Sat, 20 Jan 2024 17:05:46 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id REmerJLtNtzh2REmer7I2T; Sat, 20 Jan 2024 17:05:28 +0000 X-Authority-Analysis: v=2.4 cv=Ra6Dtnhv c=1 sm=1 tr=0 ts=65abfd58 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=3BUPImIo593mgkOj2lEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HZW2Lkf26dGb6eW3THeR/1sGc3R4oDtHb3KzF4vfGSM=; b=XoDpuZJLlmLH1P4ase05BE5ePY YZt0ajp7GJ/EpJWdwLzm7wqAlSIrqutcIJ7qOitvoh5mCFNM/WQKhNuzbFkCfiXz3o9UtwbBhOI6L K0+6XVDP5uL1hL91JZHpCFVb4; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:57166 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rREmd-003Eck-33; Sat, 20 Jan 2024 10:05:28 -0700 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 05/14] Remove tui_register_info::visible References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> <20231217-tui-regs-cleanup-v1-5-67bd0ea1e8be@tromey.com> <87edfj49q2.fsf@redhat.com> X-Attribution: Tom Date: Sat, 20 Jan 2024 10:05:26 -0700 In-Reply-To: <87edfj49q2.fsf@redhat.com> (Andrew Burgess's message of "Mon, 18 Dec 2023 19:00:21 +0000") Message-ID: <87y1ckue95.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rREmd-003Eck-33 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (prentzel) [97.122.68.157]:57166 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMaq2UFNYjaitVNQe71PVkzPrHUQwtpmurCAO7/ws9ssbX9pt7i64q86JZTxgMGjgBcf5XWye05RGOL8IBon+nxUGB6RM6js/FxE8L4+LwqBQYkovAnR pw5O56whI+aVPubI0DsGTC2pOkd6ImbYQ4Y21mviw4FtBA5QprQn9ti7nGROSlvBSqYRCbIRod0DEYBHzGCiaWnIkt7YW1gn0/M= X-Spam-Status: No, score=-3017.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> tui_register_info::visible is redundant with the fact that y==0 means >> that the register is not visible -- and some spots already check the >> latter. Andrew> I'm not sure moving to 'y > 0' is an improvement though... Andrew> Would a better solution be to change the visible to a member function, Andrew> defined in the header file (so it can inline)? I made this change. Tom