From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 8157B3858C2F for ; Tue, 12 Dec 2023 18:28:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8157B3858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8157B3858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702405689; cv=none; b=rv2XrkwhLqJuo5YJ9VEo6gJt7ultvYT9ZtgQu3DDtKxIz++7+fZCptSqqYo2CN8pamnCjlOqPu/lvrnd3vfO5O23mCFwvh4tvjGMZGCSsJWUSrLuGySfOPUpmLAMadD1o95E0K27DHiwDRwAk5wWhy9bMuLZJ3J6bgFYdWEuJaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702405689; c=relaxed/simple; bh=MH8E3iBP6ic2aiyAourRcCbkPV4Q8IYRRKQQk0V9GIo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oOdmmo020WT9syfX5hRIPxWnE2pycUo1b9b9kZdUl74eVBpUKRHw1NykE2sElzT+67R6o0BrykH+ovsPh3KQURnDbtqdQjq0B3hjRPw0Zm9U8szJvtOCdwwLgvGHygR3htpMZ49Bx6G11RUNu+7QCWV4lfB45INzq/SN0+8RV9I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id D2WGrYY66Vly7D7UFrpcbi; Tue, 12 Dec 2023 18:28:07 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id D7UEr1C6gkUbtD7UErUAUw; Tue, 12 Dec 2023 18:28:07 +0000 X-Authority-Analysis: v=2.4 cv=WpU4jPTv c=1 sm=1 tr=0 ts=6578a637 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=x0Xm5Hy6L4g76V-fXicA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MsimX+QOX7z+D2koI5TX4a+bVKx6l4NTaylP56sXdXA=; b=wbMH3oQHtDEDHjjk/Hp02ZOOBf 2lxiJWZov4ZzcLctsAsCwQJlX+4heJzKKCIWe+V5cmhy4VZaF6LRZaHBqq9CW4iDfUyzMlDpUNi6t H9kYsKMkpiyfA7TWM0gJSO9QT; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:46860 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rD7UE-001Gv5-0Q; Tue, 12 Dec 2023 11:28:06 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 01/13] [gdb/symtab] Refactor condition in scan_attributes References: <20231212173239.16793-1-tdevries@suse.de> <20231212173239.16793-2-tdevries@suse.de> X-Attribution: Tom Date: Tue, 12 Dec 2023 11:28:05 -0700 In-Reply-To: <20231212173239.16793-2-tdevries@suse.de> (Tom de Vries's message of "Tue, 12 Dec 2023 18:32:27 +0100") Message-ID: <87y1dzcm2y.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rD7UE-001Gv5-0Q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:46860 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfO9wjPRp2OMj4kVN/3yuRBJQcTLJrNT5VcqNmEy/p2o6xI+mj1zjMlpGFZXDfwoPekI+4sHzdGrVukxZ2jw52ZMZKBw6zFGqVv/5sBC/4o+OKtqfw9kG hXN07pRz6QCD06ygfQtE9glPzOw/ua4/1oEk299I5eed2Y+m9kBYFCEW9gTptce036GqYHcVd4DYnpxTFaRjsW7LOV2LkxZgMwA= X-Spam-Status: No, score=-3017.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Make this somewhat more readable by factoring out the condition: Tom> ... Tom> if (*parent_entry == nullptr) Tom> { Tom> if (new_reader->cu == reader->cu Tom> && new_info_ptr > watermark_ptr) Tom> ... Tom> else Tom> ... Tom> } Tom> ... Ok. Approved-By: Tom Tromey Tom