From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id C93A03858CDB for ; Fri, 8 Dec 2023 15:29:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C93A03858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C93A03858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702049368; cv=none; b=sL9xxCFX4eG2FIvRDILRFqjg8SbiXalLzg9T1z7GkHuKKxERsgHKF0pVNd3u4oclEqboGGt6wzdp8pO63AWjfr10ulbTZh89JTB9U1d8HXg+CTVT1IKcOtlApE4xM2sjEaqwg8asUePI0tzj1Ws9yFJKhMt5F4PmMkGqxFiibEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702049368; c=relaxed/simple; bh=I9iwuo5Q9SPOgumQk8c+u0ubyzM5agxO1rukeuPlBX8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lvs7LKtcP7u2z9DP3Q5hnRIUQEValxxAFpQd+gnUuNr01kKepvrKHWoPdcB4vebwz9JlhukFEYQiv8x+MR5hwoxetfKlGp2XLZFfFeKWqERSsA4FdvnLBmLvu7WiCWm1K4FZLPyzzOCzNQrlEPLBQBDbJora9AE/R4hn0zGZjx0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id BaJDrKCIvWcCIBcn8rEUcR; Fri, 08 Dec 2023 15:29:26 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Bcn7rDXclqkaTBcn7r6hGy; Fri, 08 Dec 2023 15:29:25 +0000 X-Authority-Analysis: v=2.4 cv=bY547cDB c=1 sm=1 tr=0 ts=65733655 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=WTHOkoC2j-fZtqB21egA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CcVRE2PWy/xviWnt2zVTuZADBs1mbvpHWkPFprvW/sU=; b=a7SgzFD8XSC5k91TInITY1aebT D2ahHaNJqo/eDCHuBhk4esuq6W6pIPUo43vH8P3bWNGDlynldz4qtTCxjb7cTMGJ8Khl4jie09G5r ONLgA0bhYdh4X3kiGy1yG4opp; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:57570 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rBcn6-000hyK-38; Fri, 08 Dec 2023 08:29:25 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH v2] [gdb/tui] Show regs when switching to regs layout References: <20231126075250.31557-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 08 Dec 2023 08:29:24 -0700 In-Reply-To: <20231126075250.31557-1-tdevries@suse.de> (Tom de Vries's message of "Sun, 26 Nov 2023 08:52:50 +0100") Message-ID: <87y1e4hfvv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rBcn6-000hyK-38 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:57570 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJ2Nt/2cuprFL9lB/7eEDfq2KiSPw9TPPAdcbQ8jk0qqvFNnLEoUNcdaE7rC6zLArI9Kk3ML3nPGvJ0DnhrmhNtccMF5CblFoAH+3eoRkJBFAdmcGdHF /AKDB58I2wpayA/r413vMhE1LKlJVFVk38GLGe5yBaCZKSC9iTPYHpfqA1BXsoDy4Jxk2hn5XheQrWx8DXqX5O7bi3XWrTFniuU= X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> void Tom> tui_data_window::rerender () Tom> { Tom> + /* Calling check_register_value calls rerender again. We use this counter Tom> + to prevent enless recursion. */ Tom> + static int in_rerender; There's a typo, the function is check_register_values (missing an "s" in the comment). However, it seems bad to need new state for this. This triggered a memory -- there's already weird state in this area, see tui-hooks.c:tui_refreshing_registers. I have never understood why that is needed. I wonder if this can be untangled. Tom