From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 7118B3858D39 for ; Wed, 6 Dec 2023 17:04:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7118B3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7118B3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701882300; cv=none; b=xF4ejEknB6dTd8anHaXVjKA8879papZTfVcyY7HAgdbA5uhO4sKaD1eZAlkmGmqwSULGjRarJ2efELk3uwRTNJvhd7cld7+iHFMzyP7smYAeb0tRDKkr9klfvFVWVzUTH1f/Op62MN0Q5idtywqyZ65EFk/sUHDA2Elr00euS64= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701882300; c=relaxed/simple; bh=fBLD7GJ0K//jkyXYcsc1RcOJtS4z62Ue9OttJzv+aA0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=P/Qlfxsap5X/77UpyrnHlndq58nkm27+1eJquzPIEdc7sicKabOqkJB6Glo9DzHavdAdCBY48KRKj/VHUxn/qiqAyanGWUW+G6fidjh2gL+DDNYefwm7HNpyIest/vtTmXB4jiUjHzitMZv2eE/qvmfl/Pw0WTrvViGtulaoZVc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-7b35d476d61so228694439f.0 for ; Wed, 06 Dec 2023 09:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701882298; x=1702487098; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=VGFKdfvNOXLehWea3xWmia/Nl/tiyDXiK/lyMp0jFQc=; b=fJq/dJfnIo008JN4h1WHrx3h7Cz6BRQxIQcZc9awXhq7QoxH2E02gCSy0+D1VpqMZ2 Ddc8rvBf7EE1EKOcoFWEX1tBnmosz5+QXNYfI6MVp3fCiBqV8De+r6vpOVmtE1JvzRWX ILnAaWvjCdGURKLEZj8PCQqUdQwzzVU+2giUYQix7GCdojHboL+AWULOyj89Q0Ey2Wyl oqNbSMcfCdbDvvTqXbLjFvJ31p59DOR5RlfOw5vfyPQG/hnsPdAE1Nm2uaUc+QCXyRP2 SrYpXKkEmB3GRS4B7e0LmU1y7r1XqMdNmY8zNoYckb7jHIrOCKGwGCmCpAEE5Ze4oPnF wGXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701882298; x=1702487098; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VGFKdfvNOXLehWea3xWmia/Nl/tiyDXiK/lyMp0jFQc=; b=JzxBH/8DDFqXiavOMteHkSs3Qs/pON3vXivsACdRWVy+dz+Wjws/pb4zRrzQr3I2eb 34f1msCe78h+z07w8ptDUmUMr2WX7lCsjUCM/Dalc62oxcPTS+0b5YqNHvAmFht90GcW V8K7WptY3RB61zOgKhA67atOmcieilryDup/bE2oauGoFTeWqbkX8QhpaLdzXIvLcjGw TUL3cfNc12S2MBvliVFbAKVujPxyzrXMFQWe9+l0rU+xVIz7GTQQxjg55+UGtiUywrZw PGcpfRzXwS4yeyKTviAA7gb7RTFgdraQRbcMCiiVuQKmKzviilB+lufQKA3HSFxMwRbn H1hg== X-Gm-Message-State: AOJu0Yy0OTmYJAiH12wc4FOD6UKOnI0my1z+rci1ZzSv6q9e93OYdg7c QXzNcgAF0ANKZKGuwGEdKLsZrQ== X-Google-Smtp-Source: AGHT+IF0rJdVQbCrVbjYPtV6KMw9p7e5Y13fevBO2JR+rmNzKGzUEakWGvCgVryAJxuYKxaoXRa+jQ== X-Received: by 2002:a05:6602:1682:b0:7b3:ad0b:32c9 with SMTP id s2-20020a056602168200b007b3ad0b32c9mr1582833iow.7.1701882298529; Wed, 06 Dec 2023 09:04:58 -0800 (PST) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id p13-20020a0566380e8d00b004692292ff38sm43256jas.113.2023.12.06.09.04.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 09:04:58 -0800 (PST) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Improve Ada name lookup performance References: <20231121-ada-lookup-perf-v1-0-1efd2d1dbf65@adacore.com> <8734wfjmdl.fsf@tromey.com> X-Attribution: Tom Date: Wed, 06 Dec 2023 10:04:57 -0700 In-Reply-To: <8734wfjmdl.fsf@tromey.com> (Tom Tromey's message of "Wed, 06 Dec 2023 10:01:42 -0700") Message-ID: <87y1e7i7nq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> This series started when a user noticed that gdb was very slow to Tom> print Ada records in a large program. I tracked this down and fixed Tom> it in patch #1. However, then I noticed that, with a little work, an Tom> entire method could be removed from quick_symbol_functions. This is Tom> desirable because this method was only used by Ada. Tom> I regression tested this on x86-64 Fedora 38. I also used regression Tom> tested using the .debug_names and .gdb_index target boards. It's also Tom> been run through the AdaCore internal test suite. > I rebased this today and I think it needs a little work. It regressed > gdb.dap/pause.exp, and then when looking at that I wondered what would > happen if an inferior call caused an unexpected stop... so I think it > may need another new test as well. I meant to send this reply to the DAP "stop reason" series. I was going to send a different reply to the Ada name lookup series -- I'm checking it in. Tom