From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 563CA3858C2D for ; Mon, 27 Nov 2023 19:39:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 563CA3858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 563CA3858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701113942; cv=none; b=w3tQr4UhXOtctbChEbIwt16/RIyZ/Ia9e8P5rHZESmm5aHy2c3n60+l4kqSS1DYffRYURLABIKnpc7Rsk0Gp74KIaiUuHdr4txtQUIyiLbMl6M1oYSSQYSRU2p6htzDasjL3XMvGFW5xDQxTUbhIhTZLrJ6D9ghHkWWIa+2XUnU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701113942; c=relaxed/simple; bh=lMMqgFyAWzFQM+Pk8MvkGibxQYeNz+nxL0LXwAm8lhs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YE+UioTeHvnlzBaywliW4W3TH3lViM0GAFBBgBqbTm7Wnz/FapKW5RUSdD4TRXpCIPn/jCuaKF7WCS4RsOYDWdK2yv8rO1NGPCZCg5TWNIimyuQReQoLJsYWzheyu6DpqhINzEbMbcVxJqh8qUQRmkrQ8OwEYxCJvQHNpqoAJ/E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id 7g1Ar00eijtZ37hRhrWRTW; Mon, 27 Nov 2023 19:39:05 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 7hRbrqFP797pz7hRbrRiTx; Mon, 27 Nov 2023 19:38:59 +0000 X-Authority-Analysis: v=2.4 cv=ULDOoQTy c=1 sm=1 tr=0 ts=6564f053 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=yU2rXjmndA6uvRRTzvcA:9 a=zZCYzV9kfG8A:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=l9V9DwJbdDHNqZdzxTyNETZpUveMY+U3x3zRGXyhjG8=; b=uxb+ITp9DYIa3kwFK9i/rnN37r GqzOPk0WQ4cU9iszy62600ygbc5tl5w4M5jFVSbYiB+a5DVolzlDL8bKAoxnBv9P+XVQcl1NTZrTS u/ioXSeO+ZxrkIPOMCyqNCaH6; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:37674 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r7hRa-000q2v-2J; Mon, 27 Nov 2023 12:38:58 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Changes to gdb-index creation References: X-Attribution: Tom Date: Mon, 27 Nov 2023 12:38:57 -0700 In-Reply-To: (Andrew Burgess's message of "Mon, 27 Nov 2023 17:55:54 +0000") Message-ID: <87y1ejdm0e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r7hRa-000q2v-2J X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:37674 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCFuPQutTmWgwSXZRmPcqRXg+axZ9hiyGZM2PNM8x8TwU1F9GDc7nwYbBrh4CJtbuW/2I0UyJyeWoUI80Q9LYnaz/j6JMnBpdOXdfmI8QhukXoHkTXd6 B5Q94JmM7io/mDKgM9vFO7IJWqrm2rAo/TNtGd1Bc+pPZT6xryIgpGnumciIP2CAZP2sAtbdyWuP+Qx0lEW2VlmwQzUHaL40yjc= X-Spam-Status: No, score=-3017.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> Patches #1 and #2 are pretty straight forward improvements; don't Andrew> think they will be controversial. Andrew> Patch #4 is an interesting bug fix. Andrew> Patches #6 and #7 are what this series is really all about. Making Andrew> the indexes created by 'save gdb-index' be determenistic as the number Andrew> of worker-threads that GDB uses changes. I read through this. I was a bit worried about new gdb.gdb tests (I feel those are often more trouble than they're worth), but this one avoids the problem stuff and anyway there doesn't seem to be a better way to do it. Anyway, I sent a nit or two, everything looks good to me. Thanks for doing this, and nice find on the hash table bug. Approved-By: Tom Tromey Tom