From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 9D3F93858CDA for ; Fri, 20 Oct 2023 19:51:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D3F93858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D3F93858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697831463; cv=none; b=RuM/iFqrO+USeamiGIC18P1fqYnt4OqD06uXlWtjExlTaDNXYG8Jz1ycO5GUGsirhsGqtKWxcWLJo6tXAsyPN4oX1jwn1cczXYU1c/EB8C7qBqxUmcJ3aUapKgzSB34Q7JC4k6yAwNEn39nh2bVmJ82/WOuYh/5vKNck86HdKiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697831463; c=relaxed/simple; bh=S/1qEBEgsWFO8b98ahOmkWUzdaKwq9ByM0sXuiDPzrY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ubd+un6x8OGRUW3+igQHKBI/2qvBS/UOjVyqkiIyhh42XGuAS0g4GbCaBgKfaFHxUv9YNDHxgRLaBnci9uJl5CxhXHvIospNyk3Ot9dXvSv+JY+y/P0NHWnn6dU3kKIfRRr389XWF6ijQe8Fv5VGnVltBtyiavH0KRTCwJgLNCE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTPS id tt8Pq0QDFjtZ3tvWQqN245; Fri, 20 Oct 2023 19:51:02 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id tvWPq07iiTbebtvWQqV4gz; Fri, 20 Oct 2023 19:51:02 +0000 X-Authority-Analysis: v=2.4 cv=E8LeGIRl c=1 sm=1 tr=0 ts=6532da26 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=zZCYzV9kfG8A:10 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S/1qEBEgsWFO8b98ahOmkWUzdaKwq9ByM0sXuiDPzrY=; b=ZnusLbyqf2yMyYyWLO8e8HwcJm PJXgb+JqKoGC8cGRs4wKzCEoxKBDsMp0FHPDR/BuCsCCBXoDqZ46nUn/kFWh7I3SOCYBhcIlBBQt9 996vQ6OKZeZPxkPFlBPzQWQa0; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:41962 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qtvWP-002hoF-1B; Fri, 20 Oct 2023 13:51:01 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 02/13] [gdb/symtab] Check effect in parent_map::set_parent References: <20231002125051.29911-1-tdevries@suse.de> <20231002125051.29911-3-tdevries@suse.de> X-Attribution: Tom Date: Fri, 20 Oct 2023 13:51:00 -0600 In-Reply-To: <20231002125051.29911-3-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 2 Oct 2023 14:50:40 +0200") Message-ID: <87y1fxnkd7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qtvWP-002hoF-1B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:41962 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfH1QTe5x6JEROjHfwa8y2aUF5JTmtfDO+u8ayKcqgL2dgBRRaSNqQZB81Yp/O2uGD32Duutj1Y60KUNtEg+CSxPtn8nmyqby/sxiVf+7plK4nVDDZzFq TIXANl/036CCSzQaaPbkltQKk2asp8Ki5+X09L/nQuAMIurBOY5woZW1hU+GxNm6oIVMWKo1+HF8Fz7bZctBFbTRbxbHQ6rkGAs= X-Spam-Status: No, score=-3018.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Set_parent uses m_die_range_map.set_empty to set the parent of a range. Tom> If part of the range is already set, it remains the same. Tom> If the entire range is already set, the set_empty has no effect, silently. Tom> Fix this by verifying that calling set_empty has the desired effect on the Tom> start and end points of the range. This seems like it might be better as a unit test. Tom