From: Tom Tromey <tom@tromey.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/8] Fixes for multiprocess for FreeBSD's native target
Date: Fri, 04 Aug 2023 10:45:20 -0600 [thread overview]
Message-ID: <87y1iqah9b.fsf@tromey.com> (raw)
In-Reply-To: <20230717192039.13976-1-jhb@FreeBSD.org> (John Baldwin's message of "Mon, 17 Jul 2023 12:20:31 -0700")
>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
John> While this series is not perfect, it does result in a net improvement
John> in testsuite results on FreeBSD/amd64 and is also a significantly
John> better experience debugging forking processes. I'm less confident about
John> the last two patches but would like to get the first 6 patches into
John> GDB 14.
I skimmed through this, but I don't really know anything about FreeBSD.
Anyway I didn't see any real red flags, and I sent the one comment I
had.
John> - Patch 8 is new and adds an implementation of the stop target method.
John> It wasn't clear to me if this is really needed for an all-stop-only
John> target, but at least one test in the testsuite was calling this
John> method when I made it gdb_assert() instead of being the default.
That is interesting. I had thought it was only used for non-stop.
windows-nat doesn't implement it... but then again, I've never managed
to run the test suite on Windows.
Tom
next prev parent reply other threads:[~2023-08-04 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 19:20 John Baldwin
2023-07-17 19:20 ` [PATCH v2 1/8] fbsd-nat: Add a list of pending events John Baldwin
2023-07-17 19:20 ` [PATCH v2 2/8] fbsd-nat: Defer any ineligible events reported by wait John Baldwin
2023-07-17 19:20 ` [PATCH v2 3/8] fbsd-nat: Fix resuming and waiting with multiple processes John Baldwin
2023-08-04 16:30 ` Tom Tromey
2023-08-04 21:30 ` John Baldwin
2023-07-17 19:20 ` [PATCH v2 4/8] fbsd-nat: Fix several issues with detaching John Baldwin
2023-07-17 19:20 ` [PATCH v2 5/8] fbsd-nat: Fix thread_alive against a running thread John Baldwin
2023-07-17 19:20 ` [PATCH v2 6/8] fbsd-nat: Stop a process if it is running before killing it John Baldwin
2023-07-17 19:20 ` [PATCH v2 7/8] fbsd-nat: Defer resume of inferiors John Baldwin
2023-07-17 19:20 ` [PATCH v2 8/8] fbsd-nat: Implement the target stop method John Baldwin
2023-08-04 16:45 ` Tom Tromey [this message]
2023-08-14 17:51 ` [PATCH v2 0/8] Fixes for multiprocess for FreeBSD's native target John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1iqah9b.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).