From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id A563E3858D1E for ; Wed, 2 Aug 2023 20:07:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A563E3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 153D710038A0F for ; Wed, 2 Aug 2023 20:07:58 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RI8TqNiUy6i54RI8TqvqLJ; Wed, 02 Aug 2023 20:07:58 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QsWbYX+d c=1 sm=1 tr=0 ts=64cab79e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=gbcx-nXWp4_mA6iS7Z8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Y/BKokYrLEVk8cYF58jw4FGQNvbjRKqMTfvDjZk/xZw=; b=kKei51fMbthrRBbBmGWgaSv30W IEHXQvoHWgNFDiyU+ZHxVt6MJwlIcOXEcgxX+nBAPsTIdNKfG+UNNxTvvfhXvaW2hjwiILTGl9ET4 k6LaNIZDboojO5nZEpzCl1tzj; Received: from 75-166-148-59.hlrn.qwest.net ([75.166.148.59]:34446 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qRI8T-002hxO-1i; Wed, 02 Aug 2023 14:07:57 -0600 From: Tom Tromey To: Abdul Basit Ijaz via Gdb-patches Cc: Abdul Basit Ijaz , JiniSusan.George@amd.com, tom@tromey.com, eliz@gnu.org, blarsen@redhat.com, Nils-Christian Kempke Subject: Re: [PATCH v4 1/4] gdb, dwarf: add support for DW_AT_trampoline in DWARF reader References: <20230801224744.24433-1-abdul.b.ijaz@intel.com> <20230801224744.24433-2-abdul.b.ijaz@intel.com> X-Attribution: Tom Date: Wed, 02 Aug 2023 14:07:56 -0600 In-Reply-To: <20230801224744.24433-2-abdul.b.ijaz@intel.com> (Abdul Basit Ijaz via Gdb-patches's message of "Wed, 2 Aug 2023 00:47:41 +0200") Message-ID: <87y1itcin7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.148.59 X-Source-L: No X-Exim-ID: 1qRI8T-002hxO-1i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-148-59.hlrn.qwest.net (murgatroyd) [75.166.148.59]:34446 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Abdul" == Abdul Basit Ijaz via Gdb-patches writes: Abdul> This patch adds support to GDB for reading the DW_AT_trampoline Abdul> attribute. It stores the attribute and its value in the type_specific Abdul> part of a GDB type. This patch is implemented in preparation of the Abdul> following patches, which will add a mechanism to hide DW_AT_trampoline Abdul> subroutines from the user. Thanks for the patch. Abdul> + if (target_name == NULL) Abdul> + target_name = dwarf2_physname (NULL, target_die, target_cu); Probably your patch predates this but nowadays we're using nullptr instead of NULL. Abdul> + unrelocated_addr target_addr_reloc = attr->as_address (); Abdul> + CORE_ADDR target_addr Abdul> + = cu->per_objfile->relocate (target_addr_reloc); Abdul> + target_addr = gdbarch_adjust_dwarf2_addr (objfile->arch (), Abdul> + target_addr); dwarf2_per_objfile::relocate already calls gdbarch_adjust_dwarf2_addr, so that call isn't needed. Abdul> + gdb_printf ("%*sfunc_type_flags %u\n", spaces, "", Abdul> + (unsigned int) TYPE_FUNC_FLAGS (type)); If we're just printing the flags as an int, how about using hex instead? Abdul> - unsigned int is_noreturn : 1; Abdul> + func_type_flags flags; This should use ENUM_BITFIELD like the other spot in the patch. Tom