From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 1/2] gdb: fix possible nullptr dereference in a remote_debug_printf call
Date: Wed, 19 Jul 2023 09:01:07 -0600 [thread overview]
Message-ID: <87y1jckkss.fsf@tromey.com> (raw)
In-Reply-To: <5476235cc65b171f32663fa5e0af0a62342d1f63.1689690655.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 18 Jul 2023 15:31:45 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> While working on the next patch I triggered a segfault from within the
Andrew> function remote_target::discard_pending_stop_replies. Turns out this
Andrew> was caused by a cut&paste error introduced in this commit:
Andrew> commit df5ad102009c41ab4dfadbb8cfb8c8b2a02a4f78
Andrew> Date: Wed Dec 1 09:40:03 2021 -0500
Andrew> gdb, gdbserver: detach fork child when detaching from fork parent
Andrew> This commit adds a remote_debug_printf call that was copied from
Andrew> earlier in the function, however, the new call wasn't updated to use
Andrew> the appropriate local variable. The local variable that it is using
Andrew> might be nullptr, in which case we trigger undefined behaviour, and
Andrew> could crash, which is what I was seeing.
Andrew> Fixed by updating to use the correct local variable.
Seems obvious to me FWIW.
Tom
next prev parent reply other threads:[~2023-07-19 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 14:31 [PATCH 0/2] Exit during detach Andrew Burgess
2023-07-18 14:31 ` [PATCH 1/2] gdb: fix possible nullptr dereference in a remote_debug_printf call Andrew Burgess
2023-07-19 15:01 ` Tom Tromey [this message]
2023-08-03 9:07 ` Andrew Burgess
2023-07-18 14:31 ` [PATCH 2/2] gdb: handle main thread exiting during detach Andrew Burgess
2023-07-18 14:40 ` Andrew Burgess
2023-08-03 9:50 ` [PATCHv2] " Andrew Burgess
2023-08-23 11:26 ` [PATCHv3] " Andrew Burgess
2023-09-29 13:57 ` [PATCHv4] " Andrew Burgess
2023-10-18 9:49 ` [PATCHv5] " Andrew Burgess
2023-10-25 21:40 ` Kevin Buettner
2023-10-26 17:26 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1jckkss.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).