Re: [PATCH 3/7] gdb/debuginfod: disable pagination during downloads

[Andrew Burgess <aburgess@redhat.com>]

Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:

> Disable pagination during downloads in order to avoid inconvenient
> continue prompts "--Type <RET> for more, q to quit...".
>
> For more discussion on this issue see the following thread
> https://sourceware.org/pipermail/gdb-patches/2023-February/196674.html

Is this patch critical to the new functionality in this series?  If it's
not then you might be better spinning this patch into it's own thread.

I also echo Tom's query about why this change is needed.  I haven't read
the thread you reference above -- I want to review the rest of this
series first -- but if there's good justification for this change in
that thread then it would be nice to see that in the commit message, the
commit message is carried with the code, but the mail archive might
disappear in the future.

> ---
>  gdb/debuginfod-support.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
> index 12025fcf0c0..f4969e94b0a 100644
> --- a/gdb/debuginfod-support.c
> +++ b/gdb/debuginfod-support.c
> @@ -292,6 +292,9 @@ debuginfod_source_query (const unsigned char *build_id,
>  			 const char *srcpath,
>  			 gdb::unique_xmalloc_ptr<char> *destname)
>  {
> +  scoped_restore save_count_lines_printed
> +   = make_scoped_restore (&pagination_enabled, false);

Given you have several uses of the same pattern, it might be nice to add
a new 'scoped_restore_pagination' class, we already have lots of
scoped_restore_XXX specialisation classes.

Thanks,
Andrew

> +
>    if (!debuginfod_is_enabled ())
>      return scoped_fd (-ENOSYS);
>  
> @@ -333,6 +336,9 @@ debuginfod_debuginfo_query (const unsigned char *build_id,
>  			    const char *filename,
>  			    gdb::unique_xmalloc_ptr<char> *destname)
>  {
> +  scoped_restore save_count_lines_printed
> +   = make_scoped_restore (&pagination_enabled, false);
> +
>    if (!debuginfod_is_enabled ())
>      return scoped_fd (-ENOSYS);
>  
> @@ -371,6 +377,9 @@ debuginfod_exec_query (const unsigned char *build_id,
>  		       const char *filename,
>  		       gdb::unique_xmalloc_ptr<char> *destname)
>  {
> +  scoped_restore save_count_lines_printed
> +   = make_scoped_restore (&pagination_enabled, false);
> +
>    if (!debuginfod_is_enabled ())
>      return scoped_fd (-ENOSYS);
>  
> @@ -412,6 +421,8 @@ debuginfod_section_query (const unsigned char *build_id,
>  #if !defined (HAVE_DEBUGINFOD_FIND_SECTION)
>    return scoped_fd (-ENOSYS);
>  #else
> +  scoped_restore save_count_lines_printed
> +    = make_scoped_restore (&pagination_enabled, false);
>  
>   if (debuginfod_enabled != debuginfod_lazy || !debuginfod_is_enabled ())
>      return scoped_fd (-ENOSYS);
> -- 
> 2.39.2