From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id C91323858D20 for ; Fri, 5 May 2023 13:49:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C91323858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 0319A10042790 for ; Fri, 5 May 2023 13:49:31 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id uvoQpNDL5lj3AuvoQp658J; Fri, 05 May 2023 13:49:31 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=XsY/hXJ9 c=1 sm=1 tr=0 ts=6455096b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=EhTfzoodr4x-BHl6RA0A:9 a=zgiPjhLxNE0A:10:nop_mobile_phish_fin_what a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JYwCXN4sw1zZsZrUMgPrNV8J6CzpYcxQkkzr4D1biBQ=; b=uV0xZA2CYpDp1sG7xnZejQ5MIq +KGXgmwvHPjA7Jjn7OLGOzNENuItSSNycfWwee+gx/aSq5/8WlOm6sruvEnr/KYD7CAoA8c9De2NC R6nWcuG546nFshhu+a06t5grM; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:60416 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1puvoQ-002Zph-P9; Fri, 05 May 2023 07:49:30 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Simplify auto_load_expand_dir_vars and remove substitute_path_component References: <20230407180856.3403239-1-tom@tromey.com> X-Attribution: Tom Date: Fri, 05 May 2023 07:49:30 -0600 In-Reply-To: <20230407180856.3403239-1-tom@tromey.com> (Tom Tromey's message of "Fri, 7 Apr 2023 12:08:56 -0600") Message-ID: <87y1m2sxat.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1puvoQ-002Zph-P9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:60416 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Tom Tromey writes: > This simplifies auto_load_expand_dir_vars to first split the string, > then do any needed substitutions. This was suggested by Simon, and is > much simpler than the current approach. > Then this patch also removes substitute_path_component, as it is no > longer called. This is nice because it helps with the long term goal > of removing utils.h. > Regression tested on x86-64 Fedora 36. I'm checking this in now. Tom