From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id B6CF23858C2C for ; Mon, 20 Mar 2023 13:43:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6CF23858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 7DDDF1003A110 for ; Mon, 20 Mar 2023 13:43:29 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id eFnNp8fuCZEg8eFnNpIPFG; Mon, 20 Mar 2023 13:43:29 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=R+zGpfdX c=1 sm=1 tr=0 ts=64186301 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=GRBvFQI6IzQZIS_EES8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iWk0R+zwapODdDeeZwD05bK2xNgnE4KGrHbzWB1/1MQ=; b=qtlomwpzR+v2wfOeur6F78PH0H rbHFEAO5qV3c09TymzfZuG2J7KqwsPTfq7cEi15num6C9Q0VnpZUIYiYjZJ1tVV0CpVXNxiEGqubW oJcV5YSN+BQpGtVG/Rwx9/VvA; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:40886 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1peFnN-003r4s-3w; Mon, 20 Mar 2023 07:43:29 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH] gdb/riscv: add systemtap support References: X-Attribution: Tom Date: Mon, 20 Mar 2023 07:43:26 -0600 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Mon, 20 Mar 2023 08:18:34 +0000") Message-ID: <87y1nrh729.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1peFnN-003r4s-3w X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (murgatroyd) [71.211.185.113]:40886 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3017.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> One thing I wasn't sure about is if the SystemTap support should be Andrew> Linux specific, or architecture specific. For aarch64, arm, ia64, and Andrew> ppc, the SystemTap support seems to libe in the ARCH-linux-tdep.c Andrew> file, while for amd64, i386, and s390 the implementation lives in Andrew> ARCH-tdep.c. I have no idea which of these is the better choice -- or Andrew> maybe both choices are correct in the right circumstances, and I'm Andrew> just not aware of how to choose between them. It's really an ELF feature, but in practice AFAIK it is only used on Linux. Putting it in the arch tdep file seems fine to me, but nothing bad will happen if it is in the linux-tdep file. Andrew> Anyway, for this patch I selected riscv-linux-tdep.c (though clearly, Andrew> moving the changes to riscv-tdep.c is trivial if anyone can why that's Andrew> a more appropriate location). It makes sense to me that SystemTap Andrew> might be a Linux only tool, which is why I picked the Linux tdep file. Yeah, they are called SystemTap probes but really they are just implemented as a single header file that could be used elsewhere. Tom