From: Tom Tromey <tom@tromey.com>
To: Hui Li <lihui@loongson.cn>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: LoongArch: Added support for static data member in struct
Date: Fri, 24 Feb 2023 12:14:11 -0700 [thread overview]
Message-ID: <87y1omho58.fsf@tromey.com> (raw)
In-Reply-To: <20230224005441.9104-1-lihui@loongson.cn> (Hui Li's message of "Fri, 24 Feb 2023 08:54:41 +0800")
>>>>> Hui Li <lihui@loongson.cn> writes:
> As described in C++ reference [1], static data members are not part
> of objects of a given class type. Modified compute_struct_member ()
> to ignore static data member so that we can get the expected result.
Looks good to me. I don't know this arch but it's normal for tdep code
to have to do this.
Reviewed-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-02-24 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 0:54 Hui Li
2023-02-24 19:14 ` Tom Tromey [this message]
2023-03-02 1:22 ` Hui Li
2023-03-02 14:42 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1omho58.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=lihui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).