From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 524673858C50 for ; Thu, 9 Feb 2023 14:01:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 524673858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id A076F100410CC for ; Thu, 9 Feb 2023 14:01:30 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Q7UQpqdCfOscKQ7UQpQV8K; Thu, 09 Feb 2023 14:01:30 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Y5c9DjSN c=1 sm=1 tr=0 ts=63e4fcba a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=IYmzO2nRNLCDObswgp8A:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=I2URVdszKHdyLj3hFMRsxd5CeW52/bvZSMnWcgfxsGU=; b=O7w/1/+Jugb3UIOCvEMtHQkIor 8FTMdioRUpuayyZR3aYaWQNOqWOX/4mk3WJtBSCJ9dlkkeocWwLj+5Soc4NMvnLeGrgXiIzgHMXDu bcVo0oEBTJrK284N/WBmnnO8U; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37374 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pQ7UQ-003Q4d-5h; Thu, 09 Feb 2023 07:01:30 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH] gdb: remove unnecessary 'dir' commands from gdb-gdb.gdb script References: <51bcb8afd665fed00ce44e7eb33846d8444feea9.1675876331.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 09 Feb 2023 07:01:27 -0700 In-Reply-To: <51bcb8afd665fed00ce44e7eb33846d8444feea9.1675876331.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Wed, 8 Feb 2023 17:13:46 +0000") Message-ID: <87y1p7ym2w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pQ7UQ-003Q4d-5h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:37374 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> While debugging GDB I used 'show directories' and spotted lots of Andrew> entries that didn't make much sense. Here are all the entries that are Andrew> in my directories list: Andrew> However... I'd like to propose that we instead remove all the extra Andrew> directories completely. My hope is that, with more recent tools, the Andrew> debug information should allow us to correctly find all of the source Andrew> files without having to add any extra 'dir' entries. Obviously, Andrew> commit 67f0714670383a does make me a little nervous, but the Andrew> gdb-gdb.gdb script isn't something a non-maintainer will be using, so Andrew> I think we can afford to be a little more aggressive here. If it Andrew> turns out the 'dir' entries are needed then we can add them back, but Andrew> actually document why they are needed. Plus, when we add them back we Andrew> will use @abs_srcdir@ instead of @srcdir@. Makes sense to me. Reviewed-By: Tom Tromey Tom