From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7BB173858D20 for ; Fri, 3 Feb 2023 15:56:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BB173858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675439786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NDAukcbbg8CcyQmNjytQkbkgIzKoYwbfT3l/MBUSaGY=; b=NCN7nhgJNckShee8qwm/9e7wT+uQJaUdM0SACkwao8FBjUanrqxuh/F5Ch9PV+5qbNRbjH 0z+lTkNOW5iMAIQZmKjyP+iZwQf/VrvaPUl/fwvlOT57iGmLpzXVhd184di7oEItneAssX mTeIgMTNGchz08B3CXW1Qznk579Bpc8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-313-RjfN1eygNkWLgJFD6X1BFg-1; Fri, 03 Feb 2023 10:56:25 -0500 X-MC-Unique: RjfN1eygNkWLgJFD6X1BFg-1 Received: by mail-qk1-f197.google.com with SMTP id h13-20020a05620a244d00b006fb713618b8so3564772qkn.0 for ; Fri, 03 Feb 2023 07:56:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NDAukcbbg8CcyQmNjytQkbkgIzKoYwbfT3l/MBUSaGY=; b=qSO15dWTMubvTP1f1PVAvNmKrTBfci1/SUZSljeNRf8Bldukr8H1ycZyNl6hhsQCGg GufbbjLPUkqJftlLaZevGtzuPg0NrKeQdeV2v66VcUFgFG5N5uBfCvb1T8lFzGD5DUxL pEoce2kZW7kQDK9mJ54Q/ZydcwiYumha8pHnEImsfd6AnROxbUdyJ3MQyLPdpJp0qLre k1Rln/0sHTctPfu2NMPfD9uDWsBjMDXZFCcZnkec/G4X/fm3YKZO8uBP6gpnfDgtHDEQ uytUDvxUGmRdG4wNYAlUiIsH3I4lKrfc6Jtu8SLatZt95PsxSc8TgwZYyoBEjSDyXOSr dUiw== X-Gm-Message-State: AO0yUKWQQXexEauuCKo9KiK+bfjvAyuFVPPFC0MF204l2GMPLQvEvqOg 2cXMq1JoaX2SsgiaHEB2fZNfCX8wQlfbA9xpv8GcWs+dSIomtLdeMIkeWM6bZl7Ijh95hVFYUax 31XyJd8XWYZ50gUjr3AZus64gxmCFZGe0yVbd8QT4wAscqOPBpdnPir+5ee8s22dq/EoEoU6MfA == X-Received: by 2002:ac8:7d01:0:b0:3af:b6bd:aba7 with SMTP id g1-20020ac87d01000000b003afb6bdaba7mr18908929qtb.43.1675439784460; Fri, 03 Feb 2023 07:56:24 -0800 (PST) X-Google-Smtp-Source: AK7set9WXT9lnCI9PKoubWIYHD1PyuZ3uCJjZuIyDQgrGntvPy/AKsDoDyq7dHKMhn9FEjC7AJ16SA== X-Received: by 2002:ac8:7d01:0:b0:3af:b6bd:aba7 with SMTP id g1-20020ac87d01000000b003afb6bdaba7mr18908892qtb.43.1675439784152; Fri, 03 Feb 2023 07:56:24 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id n13-20020ac81e0d000000b003b9a4a497a1sm1752017qtl.86.2023.02.03.07.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 07:56:23 -0800 (PST) From: Andrew Burgess To: Simon Marchi via Gdb-patches , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 0/5] Some target_desc_info cleanups In-Reply-To: <20230203142126.286866-1-simon.marchi@polymtl.ca> References: <20230203142126.286866-1-simon.marchi@polymtl.ca> Date: Fri, 03 Feb 2023 15:56:22 +0000 Message-ID: <87y1perbdl.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi via Gdb-patches writes: > While reviewing another series, I noticed some things about > target_desc_info that could be cleanup or simplified. Took a look through the series. Everything looks like a good cleanup to me. Thanks, Andrew > > Simon Marchi (5): > gdb: move target_desc_info to inferior.h > gdb: change inferior::tdesc_info to non-pointer > gdb: remove get_tdesc_info > gdb: remove copy_inferior_target_desc_info > gdb: make target_desc_info_from_user_p a method of target_desc_info > > gdb/inferior.c | 7 +--- > gdb/inferior.h | 30 ++++++++++++++- > gdb/infrun.c | 4 +- > gdb/target-descriptions.c | 81 ++++----------------------------------- > gdb/target-descriptions.h | 19 --------- > 5 files changed, 41 insertions(+), 100 deletions(-) > > > base-commit: e3ee979c1f24984eb93b32822338aa425afbc2af > -- > 2.39.1