From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 7ADA63858421 for ; Wed, 18 Jan 2023 19:13:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7ADA63858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd29.google.com with SMTP id r71so7920904iod.2 for ; Wed, 18 Jan 2023 11:13:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Mve5L8+WZvhAy0eQ9U20/21tnJPDf0tPGKgKrLcfTEc=; b=ZACHeL4O3MhBL66U1qx+ObBnKw/JIGidWC7uoKJQ+aWqVp38DpQB3khJJzxfU+OxVL 1HM+uPSXuV0v4Ncm/zUPvrpMpqRfkp6GIPlhvntpOzDmoFjXNGr1Efl+4dwdjj0/k/ix hbufCdHNigW5sHMBeuV4o7nRlpnID1LU4+JpLrDccy0yOqgo2gqEqf6ozhbiXjMHNkYq T6UqiNo7kyUtB4ZUU2YrDQQhc9gLrrhCJzBcCH2qLzScdvEBcvJLWEMzjdTI83aY7BzZ +rZ0n0KuIUlm9yqHZOESxqy1I5MdhaZVC7sN42whupZtk0OPc0qtjdyaoI5VNHdkimkZ 6Xrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mve5L8+WZvhAy0eQ9U20/21tnJPDf0tPGKgKrLcfTEc=; b=wkz+SkpjZZeEz/hzhTy1/Uiz30sqFXhG1htwrnm+r+qlEgZOGWlR6z33BNVTb4PZEo DKc2aeHcQdgpbkXRcZIY7WZz+p3MpxsLRTw8EWsjgjeTQuNll4RROAcpeSgTK2IXlahK xVsmTSMfN9V1vQIt3c/G3F369rX9XrA041cWncG6ScId3src/Alg4Jl4yzYBmIZbuDLz tT2BAn51j1HVZtvoXpH9sIwargi04Xq3Wx3gCl+wdDKY2X7lhcM/goAsLJo24XNeYOv9 G4czVwCexF4S8prXaWFANc5cSDqD2uY71IfLK1bEtW3xl3Vlw3xdLEJ6WeMXmWEk7xKZ ERMg== X-Gm-Message-State: AFqh2kp/ldtwyVYtVXmAqu5JP5Zy59DtaznmlLpgQI9TPrj528KCbrrN m9T6L7ZV/teCU+492qoIbaOms/dO2S2M51sg X-Google-Smtp-Source: AMrXdXtKCs69tm7JnIzL3Do0OsU0B7gYzrg0YC2l2RsEpIx9D0qSWeOwXcV8FQkzkQ22COUOEu4mIg== X-Received: by 2002:a6b:8e4a:0:b0:6e0:10d4:6ac7 with SMTP id q71-20020a6b8e4a000000b006e010d46ac7mr20268550iod.7.1674069187722; Wed, 18 Jan 2023 11:13:07 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id q3-20020a02b043000000b003a174bd44eesm4339487jah.81.2023.01.18.11.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 11:13:07 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Use default section indexes in fixup_symbol_section References: <20230118153025.342512-1-tromey@adacore.com> <20230118153025.342512-2-tromey@adacore.com> <01e52cad-f3ee-41e2-661c-eb95b1b6adc6@simark.ca> X-Attribution: Tom Date: Wed, 18 Jan 2023 12:13:06 -0700 In-Reply-To: <01e52cad-f3ee-41e2-661c-eb95b1b6adc6@simark.ca> (Simon Marchi's message of "Wed, 18 Jan 2023 12:19:03 -0500") Message-ID: <87y1pzzmf1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> -void >> +static void >> fixup_section (struct general_symbol_info *ginfo, >> - CORE_ADDR addr, struct objfile *objfile) >> + CORE_ADDR addr, struct objfile *objfile, >> + int default_section) Simon> Could you expand the comment above to describe default_section? I did this, but note the comment is deleted again in patch #6 when the two functions are merged. Tom