From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 9A8073858C39 for ; Fri, 13 Jan 2023 14:07:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A8073858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id C25BA100401E5 for ; Fri, 13 Jan 2023 14:07:40 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id GKiap7xOwdsQpGKiap9emv; Fri, 13 Jan 2023 14:07:40 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=JaV5EWGV c=1 sm=1 tr=0 ts=63c165ac a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=T_Alst9gAAAA:8 a=NKbnxB3KweeoY_PngxMA:9 a=DvZ5ixILWSEuw56YIEpp:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=A0Fsud21wCcYwQ7qmbt443FD9Awvwift6pFSxFbALuk=; b=miO1pWz126KYFMuyAjMDlmyVtb iucG6BCCRktO58ixqB1r6Iv0P5T1WIB4KKJz+0QJhG6lzitNNyRCObOMyM5lubZw2EE0sdw3XS4Zl 2Zr9vDiSJFsXBcjANBpQ9MlhX; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:42686 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pGKia-0048OL-9f; Fri, 13 Jan 2023 07:07:40 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 79/79] Consolidate calls to require References: <20230112030052.3306113-1-tom@tromey.com> <20230112030052.3306113-80-tom@tromey.com> <2e1baa96-5289-537f-5bb4-f128056f6583@palves.net> X-Attribution: Tom Date: Fri, 13 Jan 2023 07:07:38 -0700 In-Reply-To: <2e1baa96-5289-537f-5bb4-f128056f6583@palves.net> (Pedro Alves's message of "Fri, 13 Jan 2023 12:48:49 +0000") Message-ID: <87y1q64jf9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pGKia-0048OL-9f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:42686 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: >> -require support_displaced_stepping >> - >> # The testfile uses "run". The real bug happened only for ![is_remote target]. >> -require !use_gdb_stub >> +require support_displaced_stepping !use_gdb_stub Pedro> I'm not really sure consolidation when we have a comment describing each "require" line Pedro> before is an improvement. For example, above, it was clear before that the use_gdb_stub Pedro> requirement was related to "run". Afterwards, it is not clear whether the Pedro> support_displaced_stepping check is related to the comment. TBH I think the comments should generally just be removed, because the "require" line seems like sufficient explanation to me. WDYT? Tom