From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 6C5133838CF2 for ; Fri, 9 Dec 2022 17:42:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C5133838CF2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 624A210048171 for ; Fri, 9 Dec 2022 17:42:42 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 3hOUpBNyeEFBm3hOUpOKzG; Fri, 09 Dec 2022 17:42:42 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=b613XvKx c=1 sm=1 tr=0 ts=63937392 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=RjGxGhYPIJW0krXOGq8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=93H/hRMb14mBb7CgMpAo6OrrA3l80PzqSuduti3park=; b=lhzsK2aUNA3ACXuhQX0XxFI3TU crL7opT45PY8+Lc5nqwSzvQ8Qn24Lzh4MhdVnLYtdSLdRkiDMS7mPIhU8OZrP5U6u1WWZKxCjn06t fws2TdIOQ/Ie4svapxTX09sVi; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56948 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p3hOT-003cdG-Pt; Fri, 09 Dec 2022 10:42:41 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH 2/2] gdb: add SYMBOL_LOOKUP_SCOPED_DEBUG_ENTER_EXIT References: <73bdc6db114e7a511a2b91d9a9f5ac6f9f589881.1670348436.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 09 Dec 2022 10:42:39 -0700 In-Reply-To: <73bdc6db114e7a511a2b91d9a9f5ac6f9f589881.1670348436.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 6 Dec 2022 17:42:09 +0000") Message-ID: <87y1rgh3sg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p3hOT-003cdG-Pt X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56948 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,TXREP,T_SPF_TEMPERROR autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> After the previous commit converted symbol lookup debug to use the new Andrew> debug scheme, this commit adds SYMBOL_LOOKUP_SCOPED_DEBUG_ENTER_EXIT. Andrew> The previous commit updated 'set debug symbol-lookup' to use the new Andrew> debug scheme, however SYMBOL_LOOKUP_SCOPED_DEBUG_ENTER_EXIT still does Andrew> not exist. The reason for this is that 'set debug symbol-lookup' Andrew> controls an integer variable, rather than a bool, and, depending on Andrew> the value of this variable, different amounts of debug will be Andrew> produced. Andrew> Currently the *_SCOPED_DEBUG_ENTER_EXIT mechanism will only work for Andrew> control variables of type bool, this is because the underlying Andrew> scoped_debug_start_end class can only handle variables of type bool. Andrew> This commit templates scoped_debug_start_end so that the class can Andrew> accept either a 'bool &' or an invokable object, e.g. a lambda Andrew> function, or a function pointer. Andrew> The existing scoped_debug_start_end and scoped_debug_enter_exit macros Andrew> in common-debug.h are updated to support scoped_debug_enter_exit being Andrew> templated, however, nothing outside of common-debug.h needs to change. Andrew> I've then added SYMBOL_LOOKUP_SCOPED_DEBUG_ENTER_EXIT in symtab.h, and Andrew> added a couple of token uses in symtab.c. I didn't want to add too Andrew> much in this first commit, this is really about updating Andrew> common-debug.h to support this new ability. This seems fine. I suppose inlining will make it not cost too much... ? Andrew> +#define SYMBOL_LOOKUP_SCOPED_DEBUG_ENTER_EXIT \ Andrew> + scoped_debug_enter_exit ([&] () -> bool { \ Andrew> + return symbol_lookup_debug > 0; \ Andrew> + }, "symbol-lookup") I wonder whether the [&] is needed here. I couldn't see what it is capturing. Tom