From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D9BC2385840A for ; Mon, 24 Oct 2022 16:30:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9BC2385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666629026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m+hj8bcX1GApahHFE/1hBE5PH6b9aLZFkVhyvwG8kVY=; b=F9rezy5KSwY6yljm9eG/psqA5RrLwsrEY5n5R0CJGJJhiCu3XUfxBJGcnJ+/w/qB7NOCSe o6UXgPhbU3PQGS5hRyGjHn87Heh1N/DB/yOh+J1kt6vu9aIiTt1pM0VA/eKRzYPK1go+Px MlFW8WpjRtFc0L2Mz8Orv0fP2Hp93Po= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-325-InjtPt94O-m84M_IFWrfQA-1; Mon, 24 Oct 2022 12:30:24 -0400 X-MC-Unique: InjtPt94O-m84M_IFWrfQA-1 Received: by mail-qk1-f199.google.com with SMTP id u9-20020a05620a454900b006eeafac8ea4so9364559qkp.19 for ; Mon, 24 Oct 2022 09:30:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m+hj8bcX1GApahHFE/1hBE5PH6b9aLZFkVhyvwG8kVY=; b=ZEIKtBzTSKyBpyMncxVdeYhD1xAfPhmC0oVyO0QX20bSfOcD50XdJTFSvH1lMEgMGs nWFt9v49Zn87MTWpC7sBoxcBJ4fKAIo/JQhOvnj/PTZ/VrF/ymJvrTaQwLQo/Ir/DeLw U16lK+UjWNc+onC0qbYFKPc6rCFFBy3cgkhpfh9YYrmIx0bfrxz3ndMNO21J5WljkpIS DB4Hc6N3TULMQR/0JGrqC9Yuc+t39t9xVjk2hagChsstAQ9jowSj0Ie8MfsRal5Sjvxh 03OV0XKCzsjrFBAzhB8OJu0kYxkmuqxDrNUteyBN1pqAJty5EQ9qrEx+3eAZDa1JLXqs SEPw== X-Gm-Message-State: ACrzQf2vhj8m4IsAsVDPsoVs2AsHLEkRexcWE9lfYBYdUPVSc04HmRYC 7c7B+DhlfK1YEDRH57VMZLVvL7eIsjyWNkBf0i6d9OQY65k9MXS5xF7+jDzsYShaKrWoLxSB3gf YyQT/zEUs20Hl7HR2mPhX0g== X-Received: by 2002:a05:6214:29e9:b0:4b1:8d19:a2e8 with SMTP id jv9-20020a05621429e900b004b18d19a2e8mr28672681qvb.46.1666629024316; Mon, 24 Oct 2022 09:30:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5TYRFe3QBvGi0qLnpeWtiPCYc3DXnOj/UzacYV81MdkaRGwhdPVKDevMrWKNUwy1jicl+pLg== X-Received: by 2002:a05:6214:29e9:b0:4b1:8d19:a2e8 with SMTP id jv9-20020a05621429e900b004b18d19a2e8mr28672658qvb.46.1666629024023; Mon, 24 Oct 2022 09:30:24 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id f8-20020ac84708000000b0039c9d0dcaf8sm145220qtp.85.2022.10.24.09.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 09:30:23 -0700 (PDT) From: Andrew Burgess To: Tsukasa OI , Tsukasa OI , Mike Frysinger , Nick Clifton Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 34/40] sim/rx: Mark unused function In-Reply-To: <568d957b97fadfee53f3450dfd083ca895d1f0bf.1666258361.git.research_trasio@irq.a4lg.com> References: <568d957b97fadfee53f3450dfd083ca895d1f0bf.1666258361.git.research_trasio@irq.a4lg.com> Date: Mon, 24 Oct 2022 17:30:22 +0100 Message-ID: <87y1t56v6p.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tsukasa OI writes: > Clang generates a warning if there is a unused static function > ("-Wunused-function"). On the default configuration, it causes a build > failure (unless "--disable-werror" is specified). > > Although that this is completely unused, the author considers that this is > _happened to be_ unused and choose to keep this function for now. What does "happen to be" mean? The function isn't used, right? I'd like to request this patch not be merged. I think the function should just be deleted as unused. If/when there's a need for it, we can just bring it back. Thanks, Andrew > > Instead, this commit adds ATTRIBUTE_UNUSED. > --- > sim/rx/rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sim/rx/rx.c b/sim/rx/rx.c > index 70b1b9729b7..8646c20d108 100644 > --- a/sim/rx/rx.c > +++ b/sim/rx/rx.c > @@ -754,7 +754,7 @@ typedef union { > float f; > } FloatInt; > > -static inline int > +static inline int ATTRIBUTE_UNUSED > float2int (float f) > { > FloatInt fi; > -- > 2.34.1