From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 5FFA43856942 for ; Thu, 28 Jul 2022 17:47:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5FFA43856942 Received: by mail-oi1-x231.google.com with SMTP id bb16so3169891oib.11 for ; Thu, 28 Jul 2022 10:47:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=acVZgvcsCiwHgXq8AwoHx0YX+qQqctsilRIw1k7laSQ=; b=x0FggP+PVBs89kqNbIrAAeITGtLsNKwSR+jaVa/knRW8fjCEtLVzH0uw96U4SNmQOl PRT+nkEpeG3k50UhcSZ+O6IpGSEsggX2fhWwCEkR+i31CxX8PI6tFNV5aNAuHJIOdhtw zbq+1LWPDRuUsD9tJWBc0vKiEx7vQfkLDvu7f76Uc3mnPAgNhQ9Mmt5aKLi8h5u5jbhX MtaFzMPN0TyURe7CEo3sG/mgdXy4PkAcREv4La/eRCYSQr/O12hpT6QMOSqGA8ilZOF9 Ns4MdtjIB6lhl6nlEqwJagtxevKZBTpKR0SdEdJgq6FLjvIyAx8ODq1avu7ZmPYbc96G XIwg== X-Gm-Message-State: AJIora/aYuwPGuTIQFHPZ2TfEi/uK7k2NyaThnuJ68QXMx2WgtyKsr5P UE+NumkrluEXQShD7kKV2ugHgw== X-Google-Smtp-Source: AGRyM1sx0vO+USa2i4TaH8nHrbD7mDrOcPj0lpW0pVjMIBynvZS4wK1KAb9zWvOKaiuiPk/OsUZfow== X-Received: by 2002:a05:6808:238f:b0:33a:c360:207b with SMTP id bp15-20020a056808238f00b0033ac360207bmr255244oib.78.1659030467732; Thu, 28 Jul 2022 10:47:47 -0700 (PDT) Received: from murgatroyd (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id p18-20020a056870831200b00108b31bf8fbsm597008oae.53.2022.07.28.10.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 10:47:47 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey , Simon Farre Subject: Re: [PATCH v7] gdb/python: Add BreakpointLocation type References: <20220607115748.484438-1-simon.farre.cx@gmail.com> <87r12nslj7.fsf@tromey.com> X-Attribution: Tom Date: Thu, 28 Jul 2022 11:47:46 -0600 In-Reply-To: <87r12nslj7.fsf@tromey.com> (Tom Tromey via Gdb-patches's message of "Thu, 14 Jul 2022 10:31:56 -0600") Message-ID: <87y1wdi0xp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 17:47:50 -0000 Simon> +static int find_loc_num_by_location (bp_location* loc); Tom> I think it would be better to rearrange this so that the forward Tom> declaration isn't needed. [...] I have been wanting this patch for a project I'm working on, and so I went ahead and made the minor code tweaks needed -- a few formatting fixups and a couple of missing Python error checks. I didn't change the documentation, since I feel that may require some discussion first. I'm going to check it in now. Thank you for doing this. Tom