From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 186D6383F957 for ; Fri, 24 Jun 2022 15:57:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 186D6383F957 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659-TQWJF3aIOIy193O1XaCYIA-1; Fri, 24 Jun 2022 11:57:43 -0400 X-MC-Unique: TQWJF3aIOIy193O1XaCYIA-1 Received: by mail-wm1-f69.google.com with SMTP id l17-20020a05600c4f1100b0039c860db521so1640297wmq.5 for ; Fri, 24 Jun 2022 08:57:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=3FJXhSoYoobn7bndxsUjOKGCLVkOksX4+dE1d0f2oxQ=; b=ql/C8x/34RdZaeoBvRGxMCKlhTsmJWX2viYgB6HEdaIly+ISHT6NZmc7ZarB3JGJmL lttniaJb1dofAABj4j5EstBEjlw6H5QnGf8qWhgrpFueHnVoxus7IIHpm8dA4A5O3+es ly+NjkTnMxwL/vhAig6Gwkn6pvtluPNCpkUjx7q2Dj4Ih3TWtXkB4XAVua9AWb25SgyV 4ziTkbl3omSkV/UobYkY5XQ7x2L2AksMCbULmAP/e2b4tTs0tTAPgtGvaalTMFULFS7d 0ZNqZWIoNakzOqdrwmZA3+ORLu/M4/HVPA3hgy1KQhPSpOkef3cmv95yhRVPUVRgFS2h r6Sw== X-Gm-Message-State: AJIora+s0iaw3yvdGP2bpWf1fxVVwnrz5lGTlKw/+LVlRHXbTKHqCiiZ xhskDqeX/XWmgTDxuip70lVVk4vUuIckMBMh05qNpkf2FvP1ddtmxRzIu7ywdYU66EqTtlEPuR8 cSq8v6IalEmzvaTjAhKnrFg== X-Received: by 2002:adf:d1c2:0:b0:218:5736:63d9 with SMTP id b2-20020adfd1c2000000b00218573663d9mr14009445wrd.667.1656086262112; Fri, 24 Jun 2022 08:57:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v2rYsPwCaNXg61OBQlPTet6oW5z9m9lsOTQjxCt0+8zBAXT6cqqf/tIeDJ/nZ6bZihAiI7Ng== X-Received: by 2002:adf:d1c2:0:b0:218:5736:63d9 with SMTP id b2-20020adfd1c2000000b00218573663d9mr14009437wrd.667.1656086261950; Fri, 24 Jun 2022 08:57:41 -0700 (PDT) Received: from localhost ([195.213.152.79]) by smtp.gmail.com with ESMTPSA id c1-20020a05600c100100b003a03d34b85fsm1654055wmc.25.2022.06.24.08.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 08:57:41 -0700 (PDT) From: Andrew Burgess To: "Maciej W. Rozycki" , gdb-patches@sourceware.org Cc: Simon Sobisch , Tom Tromey Subject: Re: [PATCH v5 5/8] GDB/testsuite: Add coverage for `print -elements' command In-Reply-To: References: Date: Fri, 24 Jun 2022 16:57:40 +0100 Message-ID: <87y1xm9hqj.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 15:57:46 -0000 "Maciej W. Rozycki" writes: > We currently have no coverage for the `print -elements ...' command (or > `p -elements ...' in the shortened form), so add a couple of test cases > mimicking ones using corresponding `set print elements ...' values. LGTM. Thanks, Andrew > --- > No change from v4. > > New change in v4. > --- > gdb/testsuite/gdb.base/printcmds.exp | 9 +++++++++ > 1 file changed, 9 insertions(+) > > gdb-test-printcmd-options.diff > Index: src/gdb/testsuite/gdb.base/printcmds.exp > =================================================================== > --- src.orig/gdb/testsuite/gdb.base/printcmds.exp > +++ src/gdb/testsuite/gdb.base/printcmds.exp > @@ -538,6 +538,15 @@ proc test_print_strings {} { > gdb_test "p teststring" \ > " = (.unsigned char .. )?\"teststring contents\"" "p teststring with elements set to 20" > > + gdb_test "p -elements 1 -- teststring" \ > + " = (.unsigned char .. )?\"t\"\\.\\.\\." > + gdb_test "p -elements 5 -- teststring" \ > + " = (.unsigned char .. )?\"tests\"\\.\\.\\." > + gdb_test "p -elements 19 -- teststring" \ > + " = (.unsigned char .. )?\"teststring contents\"" > + gdb_test "p -elements 20 -- teststring" \ > + " = (.unsigned char .. )?\"teststring contents\"" > + > gdb_test "print teststring2" \ > " = \\(charptr\\) \"more contents\"" >