From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1C4893814FF2 for ; Mon, 30 May 2022 09:33:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C4893814FF2 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-154-4TLtUOJPO3iLDwwwTq6PHw-1; Mon, 30 May 2022 05:33:17 -0400 X-MC-Unique: 4TLtUOJPO3iLDwwwTq6PHw-1 Received: by mail-qt1-f197.google.com with SMTP id m19-20020a05622a055300b002f940281f18so9728294qtx.22 for ; Mon, 30 May 2022 02:33:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=W4Q241FbpzACdLSaPZpXWkoZI0HtbsXa7IMlbZqe+8s=; b=MJBwkADji6n6418E7NHWXv3GLM6B/96GJWKkbjBsjqJjLyjr/O1beV9TUBJZg8T16f bm5kwmU/s+HHOK1r8jtZ2z+lcczPvF2UCzF8NHeJ9qMPbp44Nq4BitWGUyi4xx2GL0S+ m/LNJUBNtlqcMSHEdJ++l7mrhXmFz63jyRkD+v5lzp2y7XjO5y0RORBmMdEN3XPKAdfS lG4J+v+qVETBhFHtx83zC9dF0lKXXvBVSLCkgXNlEkOdp3iUOaZNt7KJyNUxX/1HmTFN wEtWnxWI95Ms5tEb8TsNZRKr2SsVRzmnf9tut1lWESQEzoDLFWFt0/hauvLvp60Mppgk Nk2A== X-Gm-Message-State: AOAM5316/qcXkEjzoTejAKk8dxZ1g08nHTtYqCmZgw8jAZAWi/948G2W xUhntSMWqopRvb9IpkuizloVhTnt+O2skg+GY42WR8VKPPg2rBH5VnXaG+4RzRQq7d/hGSW28GB 5kUO4Xy8QAMyqrum1+4a6kUwaToKGKMdKYEvFHI34UzzvamWnBgrWGnPjiMV3zVUVDo0TdFQ9Qg == X-Received: by 2002:a05:620a:1397:b0:6a3:8dfe:85dd with SMTP id k23-20020a05620a139700b006a38dfe85ddmr25932040qki.613.1653903196522; Mon, 30 May 2022 02:33:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7l6faqhRQfaIlSZ9ZKpBdj5vVFbbkYsjt01PGCqHZMACEynwFFRf8xQgScZbj1sEsUUuaIQ== X-Received: by 2002:a05:620a:1397:b0:6a3:8dfe:85dd with SMTP id k23-20020a05620a139700b006a38dfe85ddmr25932022qki.613.1653903196236; Mon, 30 May 2022 02:33:16 -0700 (PDT) Received: from localhost (host109-152-215-36.range109-152.btcentralplus.com. [109.152.215.36]) by smtp.gmail.com with ESMTPSA id a27-20020a05620a02fb00b006a349bfcb02sm7155309qko.41.2022.05.30.02.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 02:33:15 -0700 (PDT) From: Andrew Burgess To: Paulo Neves via Gdb-patches , gdb-patches@sourceware.org Cc: Paulo Neves Subject: Re: [PATCH v2 3/3] gdb/python doc: Fix confusion between gdb.unwinders and gdb.unwinder In-Reply-To: <20220528132905.3886575-3-ptsneves@gmail.com> References: <20220528115509.3865342-1-ptsneves@gmail.com> <20220528132905.3886575-1-ptsneves@gmail.com> <20220528132905.3886575-3-ptsneves@gmail.com> Date: Mon, 30 May 2022 10:33:14 +0100 Message-ID: <87y1yje55x.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2022 09:33:21 -0000 Paulo Neves via Gdb-patches writes: > Replace gdb.unwinders with gdb.unwinder. The gdb.unwinders module does > not and trying to import it leads to errors. Other instances of the > manual correctly refer to gdb.unwinder. This patch is fine. Thanks, Andrew > --- > gdb/doc/python.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > index 444e332d752..59232750099 100644 > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -2785,7 +2785,7 @@ class. Derive your unwinder class from it and structure the code as > follows: > > @smallexample > -from gdb.unwinders import Unwinder > +from gdb.unwinder import Unwinder > > class FrameId(object): > def __init__(self, sp, pc): > @@ -2828,7 +2828,7 @@ gdb.unwinder.register_unwinder (, MyUnwinder, replace=) > An object file, a program space, and the @value{GDBN} proper can have > unwinders registered with it. > > -The @code{gdb.unwinders} module provides the function to register a > +The @code{gdb.unwinder} module provides the function to register a > unwinder: > > @defun gdb.unwinder.register_unwinder (locus, unwinder, replace=False) > -- > 2.25.1